From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15D77A052A; Fri, 24 Jul 2020 17:30:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5C4841C02D; Fri, 24 Jul 2020 17:29:59 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 4A5FD1C02A for ; Fri, 24 Jul 2020 17:29:56 +0200 (CEST) IronPort-SDR: dTw60xh8n+MGvHQ+FjOuVD+IGTTUke3damGOHRZn3bUBET+OFvROJcfbP6KpyJblTpFljl22O8 MtStJCG0ZNrA== X-IronPort-AV: E=McAfee;i="6000,8403,9692"; a="152010406" X-IronPort-AV: E=Sophos;i="5.75,391,1589266800"; d="scan'208";a="152010406" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2020 08:29:55 -0700 IronPort-SDR: 995olobjBUHWorKW/2wIZKQqOqCIlfiAYoDUrTTOIlF60G53rLvw/w8awi6f4+Htkj/YcH3Ewg XDjHJWaiQQiQ== X-IronPort-AV: E=Sophos;i="5.75,391,1589266800"; d="scan'208";a="489241541" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.87.116]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 24 Jul 2020 08:29:52 -0700 Date: Fri, 24 Jul 2020 16:29:49 +0100 From: Bruce Richardson To: Parav Pandit Cc: Thomas Monjalon , "dev@dpdk.org" , "grive@u256.net" , "ferruh.yigit@intel.com" , Raslan Darawsheh , Ori Kam , Matan Azrad , "joyce.kong@arm.com" Message-ID: <20200724152949.GD2305@bricha3-MOBL.ger.corp.intel.com> References: <20200610171728.89-2-parav@mellanox.com> <20200724110718.GB2305@bricha3-MOBL.ger.corp.intel.com> <4937496.TfPSyrM900@thomas> <20200724145007.GC2305@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jul 24, 2020 at 03:17:38PM +0000, Parav Pandit wrote: > > > > From: Bruce Richardson > > Sent: Friday, July 24, 2020 8:20 PM > > > > On Fri, Jul 24, 2020 at 03:54:33PM +0200, Thomas Monjalon wrote: > > > 24/07/2020 15:48, Parav Pandit: > > > > Hi Bruce, > > > > > > > > > From: Bruce Richardson > > > > > Sent: Friday, July 24, 2020 4:37 PM > > > > > > > > > > On Thu, Jul 23, 2020 at 11:09:03PM +0300, Parav Pandit wrote: > > > > > > From: Thomas Monjalon > > > > > > > > > > > > Drivers dependencies are evaluated in the order defined per > > > > > > their parent directory (also called class). > > > > > > This strict ordering prevent from having 2 different drivers of > > > > > > the same class with different dependencies ordering. > > > > > > This problem occurs if drivers/common/mlx5 depends on > > > > > > drivers/bus/pci, while drivers/bus/dpaa depends on > > drivers/common/dpaax. > > > > > > Having a strict ordering between directories bus and common is > > > > > > too much restrictive. > > > > > > > > > > > > That's why it is made possible to have a more fine-grain > > > > > > directory list, adding a driver sub-directory in the list. > > > > > > In this case, the isolated driver must be removed from its class > > > > > > list, and added directly in drivers/meson.build. > > > > > > Also, the per-class variables must be duplicated in the isolated > > > > > > driver, because the call "subdir(class)" is skipped in the isolated driver > > case. > > > > > > > > > > > > Signed-off-by: Thomas Monjalon > > > > > > > > > > The commit log above has some strange word-wrapping, and > > > > > occasionally strange phrasing. I think it could be slightly reworded, > > perhaps as: > > > > > > > > > I updated the commit log as you suggested below along with RB, ack tag. > > > > Thank you. > > > > > > > > > Drivers dependencies are evaluated in the order defined per their > > parent > > > > > directory (also called class). This strict ordering prevents > > > > > from us > > > > > > Is "from us" too much? > > > > The word "from" is incorrect, anyway, it should just be "prevents us". > > Evidently I didn't proofread my own text well enough. :-( > > In v10 I rephase it as "strict ordering prevents from having pairs of drivers...". Great, thanks.