From: Stephen Hemminger <stephen@networkplumber.org>
To: Tom Barbette <barbette@kth.se>
Cc: Patrick Keroulas <patrick.keroulas@radio-canada.ca>,
dev@dpdk.org, Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [dpdk-dev] [[PATCH v3 4/4] net/pcap: support hardware Tx timestamps
Date: Sat, 25 Jul 2020 04:51:17 -0700 [thread overview]
Message-ID: <20200725045117.4843df26@hermes.lan> (raw)
In-Reply-To: <cae76a86-a5bb-eeb6-f95b-cdcd9994783e@kth.se>
On Sat, 25 Jul 2020 10:35:48 +0200
Tom Barbette <barbette@kth.se> wrote:
> Nice patch!
>
> However I would use a multiply and shift approach instead of a division
> in the fast path. When we did that it was really hurting the performance.
See rte_reciprocal
next prev parent reply other threads:[~2020-07-25 11:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 20:23 [dpdk-dev] [[PATCH v3 0/4] pdump HW Rx timestamps for mlx5 Patrick Keroulas
2020-07-24 20:23 ` [dpdk-dev] [[PATCH v3 1/4] net/mlx5: query device frequency Patrick Keroulas
2020-07-24 20:23 ` [dpdk-dev] [[PATCH v3 2/4] ethdev: add API to " Patrick Keroulas
2020-07-24 20:23 ` [dpdk-dev] [[PATCH v3 3/4] pdump: convert timestamp to nanoseconds on Rx path Patrick Keroulas
2020-09-02 15:41 ` Pattan, Reshma
2020-07-24 20:23 ` [dpdk-dev] [[PATCH v3 4/4] net/pcap: support hardware Tx timestamps Patrick Keroulas
2020-07-25 8:35 ` Tom Barbette
2020-07-25 11:51 ` Stephen Hemminger [this message]
2020-07-26 22:17 ` Stephen Hemminger
2020-10-06 16:25 ` [dpdk-dev] [[PATCH v3 0/4] pdump HW Rx timestamps for mlx5 Ferruh Yigit
2020-10-07 6:59 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200725045117.4843df26@hermes.lan \
--to=stephen@networkplumber.org \
--cc=barbette@kth.se \
--cc=dev@dpdk.org \
--cc=patrick.keroulas@radio-canada.ca \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).