From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C563AA0524; Sun, 26 Jul 2020 16:56:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6258E1C0CD; Sun, 26 Jul 2020 16:55:59 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80082.outbound.protection.outlook.com [40.107.8.82]) by dpdk.org (Postfix) with ESMTP id 1C8E51C0AE for ; Sun, 26 Jul 2020 16:55:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bJ1Xeu+rYSB12YOM7gfdJP3fszWsjUpLkZ76Xtiso4l9cTW/CUP0b81a5J8oGTfKL7ZHyO+RN1b0bdB1+eXvY9hbyiJITmzZ7XYXoB6qwAR6zRestHGe0dAsHLtKxA3SXz3liYKQbCDs/qaN0Z/18fQvc7eYWs9C85uwNFBoYky/1h36OdA+Ip34L/4XZt01VhG86Rd5huXP/1yoeE49Tlhv9yMAnvlLfnJkC07GKwURj0e356loFWXEtu/3QiMrpr+3y1JkWp+Z9cgEDHU43niChHj0htanyMqG9kKLXceVqj6yStP0k+vHdkzKLO1NDVaTY0r6fKv28ZPjx88Rig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=92rl6cqTJPpUdxYCsCQXrb5CCdl1HT8vxMN5Ve74+0U=; b=BuZGCazRsW+RwTxbHmADmwtJUkEnHjrh0Z3M+drS4p0z8RDzuZKcFR/PrMgVfiFhHanbrr3gqGWS+QjemHvsLK08VfmLvYEgZoJuxWtnh3McvB5ERsV9mDRTZyEsXyO8Vdj15zbWqK29mX/AzgJX0QDjsUrYwC4Maabq2mTJO4rHJzvH0vpvd0DysHYKfSA5KIVVvVJDQg4XgzM4a/CUghB6MSrE3lcCubXKKZJb9Vd/rveocw3GcpFc8CQT5/uMri56OisiKLNfd+s2SPLL88eVCgJm7PAAQ/VMKnPWgjxemD+603lmhTOH9L9RXQzMe9tw9Uo+RHDCcXAoRC4ZOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=92rl6cqTJPpUdxYCsCQXrb5CCdl1HT8vxMN5Ve74+0U=; b=IepPk55u5bft7QYlz4eAT/EqHFY/K0rMdLOuCBXPC6r9z+CcqJTwhSAXQnowI407KmA0FC9PGuwSbBlM162veJXARO0OtO1A2vTbK1A4Mxpmgg58kw6b3KVH1qKkLw7VUtWd9tD9T0/vg1lOenT91XalpUGNA3c1aZ6XCUXhwiY= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com; Received: from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) by AM0PR05MB6225.eurprd05.prod.outlook.com (2603:10a6:208:117::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.27; Sun, 26 Jul 2020 14:55:52 +0000 Received: from AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::eccf:72b3:bacb:f09d]) by AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::eccf:72b3:bacb:f09d%5]) with mapi id 15.20.3216.031; Sun, 26 Jul 2020 14:55:52 +0000 From: Parav Pandit To: dev@dpdk.org, grive@u256.net, ferruh.yigit@intel.com, thomas@monjalon.net Cc: rasland@mellanox.com, orika@mellanox.com, matan@mellanox.com, joyce.kong@arm.com, Parav Pandit Date: Sun, 26 Jul 2020 17:55:18 +0300 Message-Id: <20200726145524.149355-5-parav@mellanox.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200726145524.149355-1-parav@mellanox.com> References: <20200610171728.89-2-parav@mellanox.com> <20200726145524.149355-1-parav@mellanox.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: DM5PR04CA0045.namprd04.prod.outlook.com (2603:10b6:3:12b::31) To AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sw-mtx-036.mtx.labs.mlnx (208.176.44.194) by DM5PR04CA0045.namprd04.prod.outlook.com (2603:10b6:3:12b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.23 via Frontend Transport; Sun, 26 Jul 2020 14:55:50 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [208.176.44.194] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: d3eefb04-8bce-42cf-2bb3-08d83173fd9d X-MS-TrafficTypeDiagnostic: AM0PR05MB6225: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:327; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YYZq1zS+EPO4PnuPGrY5teXyBiqeMVUOOC/TLN5Ea/DhCbFAtWlVR+6Ue1ri788tsBDKoh7rCpulDN6GJ/VdBtT89jiZkPS5eDHnu9rw/QBJ6WPgB6C1ja+/L/R5i+Y7vrIrQTCNSMDYOCft7VIiR9zpQB0bO+kicqqPrMRn1HCtq9BctCeW2RIqiG4PySndM1fLRcV4r8HXOVwXMaKVBk6fnX+nMDvyxAmdbD1s5InW/48SlAavcp3wRDkXIrqMtOqQAnUx6ACHeEh+8gtRserSQcYcQ/CFNlm5nmslukSS+cwY51SeGAXt4ox0mzGW X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB4866.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(396003)(346002)(39860400002)(136003)(376002)(6486002)(66476007)(8936002)(66556008)(6512007)(2616005)(956004)(186003)(66946007)(26005)(16526019)(8676002)(1076003)(6666004)(316002)(83380400001)(6506007)(107886003)(4326008)(36756003)(478600001)(2906002)(86362001)(52116002)(5660300002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: UdUZOdDLzHDqEsQf0AzElhCJykc/jk9zLOJesAVM3A6uvnDRICqLYgPdUtfeDiUvlorWH30aiBuMRTxSR0grGhAwm+/QNuW4ed1LeTIZSlSyBdgxjfbEFyR5aAusVdPYL/2GEVtGZ6uBq3eHLsQkIqpR1+S0HjTLrWPgIR/rHZXDMDDDvcGq8u/W9OZiN9GaKIrXCbPc2xvBS5vy6IevIr58VYSTDuhS9MvircPjvPnBk6v7uPOCKIa/3yjtZ+2bZWJAZHlBBKi1eiuD2Geew1i9i3pNhGmVOnd7nh5MWZ7Myij2EGMbmr41hSWKo73k444awst6VCY6HS9I6sL3j4jUg9EwhlXk8VI3hScqG2L8E3C4zkXe0QwFFoT6OUDokpPx4sqOSyiV7vXPsGC6bwIA9qzQyMm1iK6ekTme/EulReyUw1A5+6D9crrCcC7NSTkclUOrBT1o/EwyrjPsyWRjipvL7SagYapzHHlGGSElzJGBBJEsdP0AGg/e/iJH X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3eefb04-8bce-42cf-2bb3-08d83173fd9d X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB4866.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2020 14:55:52.0260 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7BWrtdMWpGovYwp3LZCOl7Ucm9dJ34qSgf1mdW995phm97RVJvEsR3subUWZxWc7DY7A6GJ40hxPajf/K50hvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6225 Subject: [dpdk-dev] [PATCH v11 04/10] common/mlx5: fix void parameters in glue wrappers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Following two errors are reported when compiled with gcc (GCC) 8.3.1 20191121 (Red Hat 8.3.1-5). drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a prototype [-Werror=strict-prototypes] drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a prototype [-Werror=strict-prototypes] Fix them by adding void data type in empty argument list. Fixes: 34fa7c0268e7 ("net/mlx5: add drop action to Direct Verbs E-Switch") Fixes: 400d985eb586 ("net/mlx5: add VLAN push/pop DR commands to glue") Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v2->v3: - new patch --- drivers/common/mlx5/linux/mlx5_glue.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/mlx5/linux/mlx5_glue.h b/drivers/common/mlx5/linux/mlx5_glue.h index c4f9b006a..734ace2a3 100644 --- a/drivers/common/mlx5/linux/mlx5_glue.h +++ b/drivers/common/mlx5/linux/mlx5_glue.h @@ -185,11 +185,11 @@ struct mlx5_glue { void *(*dr_create_flow_action_dest_flow_tbl)(void *tbl); void *(*dr_create_flow_action_dest_port)(void *domain, uint32_t port); - void *(*dr_create_flow_action_drop)(); + void *(*dr_create_flow_action_drop)(void); void *(*dr_create_flow_action_push_vlan) (struct mlx5dv_dr_domain *domain, rte_be32_t vlan_tag); - void *(*dr_create_flow_action_pop_vlan)(); + void *(*dr_create_flow_action_pop_vlan)(void); void *(*dr_create_flow_tbl)(void *domain, uint32_t level); int (*dr_destroy_flow_tbl)(void *tbl); void *(*dr_create_domain)(struct ibv_context *ctx, -- 2.26.2