From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9787A053E; Mon, 27 Jul 2020 19:48:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AD3511C0BD; Mon, 27 Jul 2020 19:47:56 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140081.outbound.protection.outlook.com [40.107.14.81]) by dpdk.org (Postfix) with ESMTP id 12FBF1C0B9 for ; Mon, 27 Jul 2020 19:47:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QOg0Z3ZnjNbdIIqNELy15lp5QCGDXWrOP6kddQWixVBeixGa1wEcdj4kUaCKDUdNIhf/pEUA7HmVn+oXqES+rh+tYrBd5jFGIfWB/9sNXyt7tdxmDxkkleTNdQk/wfW3gjUvsfeQ/Yvg5aXa23pCAKvApHImvgFP9ichm6J5/g+OPLI33NWgw9az8szQeDU2av3IiMpLfhqkbjBWq1R1jJwsdn8O7iYDq98Qy2nYeoLBhxQXWHpSw7HEz+M5T2nPzwNwj5jCMMXj6/cUuOUGBs3KdctGCARPxao+oxU89YjHeU0U66YhlBfo+70CUkTKid/J0iVQbqTEFT5trC+vqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=92rl6cqTJPpUdxYCsCQXrb5CCdl1HT8vxMN5Ve74+0U=; b=N4bz9Cjjwsq/6liz3LtgvoCuA5NLE+CFEOIa5Unf1yoAYpLVJXGQkZV2rNOnLVty7llhbg+e1/srHj4TnfUJGHpqd1xtC0Vvsmvm2aBoJQs+kLHAz+RusmxJvFzSEtr7EoZcUsyqUZ2JtN39fzxLgortleptpHqNnroqGRagYKaaKBYODjsVbEvQnr/jkQhxdhEHlSEpl++uC7TsojIQ5c3+9TRcT5GQRwIKigtzEk3jgnW1VS1r+trvLxUPRZT7lxPxfsfZ9pn2P8ZvOxlvft/0Q5/YTi82D1bP0Ml/oW6rRVrW5zrLen+VVTXSESCA52zZ2MrOwvps/eumKnXfcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=92rl6cqTJPpUdxYCsCQXrb5CCdl1HT8vxMN5Ve74+0U=; b=oWuzJn3IfCZgX9URxhH3cKAjq8Ux0a2wE0/uXOTYuJ6Az9L+0I9B0yqVICIwRUEM4fSwYkDYO3EKf9EbXGUNduIVV16H8RqR0mOKdCHO0i/etAnfqJOfKlJx7lBZQbMkSkEEgLbl66Hv7snD/Wp4bVfD6GyoaeK0AMqRNjOluvI= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com; Received: from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) by AM0PR05MB6227.eurprd05.prod.outlook.com (2603:10a6:208:10f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.23; Mon, 27 Jul 2020 17:47:51 +0000 Received: from AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::eccf:72b3:bacb:f09d]) by AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::eccf:72b3:bacb:f09d%5]) with mapi id 15.20.3216.033; Mon, 27 Jul 2020 17:47:50 +0000 From: Parav Pandit To: dev@dpdk.org, grive@u256.net, ferruh.yigit@intel.com, thomas@monjalon.net Cc: rasland@mellanox.com, orika@mellanox.com, matan@mellanox.com, joyce.kong@arm.com, Parav Pandit Date: Mon, 27 Jul 2020 20:47:09 +0300 Message-Id: <20200727174715.330117-5-parav@mellanox.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200727174715.330117-1-parav@mellanox.com> References: <20200610171728.89-2-parav@mellanox.com> <20200727174715.330117-1-parav@mellanox.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: DM5PR15CA0049.namprd15.prod.outlook.com (2603:10b6:3:ae::11) To AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sw-mtx-036.mtx.labs.mlnx (208.176.44.194) by DM5PR15CA0049.namprd15.prod.outlook.com (2603:10b6:3:ae::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20 via Frontend Transport; Mon, 27 Jul 2020 17:47:49 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [208.176.44.194] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 0b32b1a2-72e5-4123-dfa2-08d832552e84 X-MS-TrafficTypeDiagnostic: AM0PR05MB6227: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:327; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bk1/+iPFLFaFqu/N05KIGtFKOsIfC6B1HsosnADxQ49W8SxMUsHB210H/FIfuycr780orGuWMUX+VGCOPx+DZzQXSw3Qupj1D0WT7P9Gp5+c0pf3CYtd23HOc3QpK7nuq1P+NkJfFO0UG+lFH0rPDgu86VRPu+m8VuNVPrCwb8A4OArvsrM6WQT3zMvCq0RjDGBg4NfNSEJkhCpUT1CLKhErDhM58GUrx8MFtZuARmL3jNFxWWhKZJ/98PQTtRlTfsWAIdZQ83USEJrJg3hKzwRmPmc4ituKEwohjeGb7xYc9HgGP03DVmHpqppI6akI X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB4866.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(136003)(366004)(396003)(39860400002)(346002)(52116002)(6506007)(2906002)(316002)(6486002)(1076003)(5660300002)(8936002)(8676002)(478600001)(6666004)(6512007)(26005)(16526019)(186003)(66946007)(66556008)(66476007)(86362001)(2616005)(956004)(107886003)(4326008)(83380400001)(36756003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: rwSiWh9BLOHUwO6pd30lJmf/eok8jz8OowO0NUcYn0UCOglK1gA6H9xYHFqQfxtn15m8YnVE8QQDyQFUpXw2U7yHGBWrgchelvPJvvRFralrL3HIipNJmwRDQqgWh9Dmqw+usBJZ3ih2Jb4QYzFTrufrIPuUe8HU8HDsr9/WC3L/6/kYBVnli8Jl2+iwucEwlNpVGOMFLAqLqUpYmtixpSd92SQHxSYxavUtuUGeIGl+MiwgmvUNpXksK9tkz+Nns0a7yao5MomMXLehmK/6vvPBAaGKWDGIkn8eqaC5HKHlT4PAfe72S0CDVwtsthh3Ncy7uNoTuM4LfX7dolmTBrTgGZlwi5MsDxFN9oF0GxCfkqWG11lBbTvq6tMeebcABiyV7uB3Wuc/FZy0mdQWCHCP4ypFCOmM3fc/xcOAzcKfJEYejw7GQaIyX62RcptZ5kS2jNpnxNezMA6gXz23uST3HQgq7lJ+e0CiedyGsoJmk5s3B2enx2yCBrP61vQm X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b32b1a2-72e5-4123-dfa2-08d832552e84 X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB4866.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2020 17:47:50.8902 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 09Yu6EhJLoBEooTjRjRxnPUp6UizFuz/Q22Sg2cJ+X4Mx/j5LUzndwv8Y31OTAPy/rIr3DMsqSCo43yeJ+51fw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6227 Subject: [dpdk-dev] [PATCH v12 04/10] common/mlx5: fix void parameters in glue wrappers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Following two errors are reported when compiled with gcc (GCC) 8.3.1 20191121 (Red Hat 8.3.1-5). drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a prototype [-Werror=strict-prototypes] drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a prototype [-Werror=strict-prototypes] Fix them by adding void data type in empty argument list. Fixes: 34fa7c0268e7 ("net/mlx5: add drop action to Direct Verbs E-Switch") Fixes: 400d985eb586 ("net/mlx5: add VLAN push/pop DR commands to glue") Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v2->v3: - new patch --- drivers/common/mlx5/linux/mlx5_glue.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/mlx5/linux/mlx5_glue.h b/drivers/common/mlx5/linux/mlx5_glue.h index c4f9b006a..734ace2a3 100644 --- a/drivers/common/mlx5/linux/mlx5_glue.h +++ b/drivers/common/mlx5/linux/mlx5_glue.h @@ -185,11 +185,11 @@ struct mlx5_glue { void *(*dr_create_flow_action_dest_flow_tbl)(void *tbl); void *(*dr_create_flow_action_dest_port)(void *domain, uint32_t port); - void *(*dr_create_flow_action_drop)(); + void *(*dr_create_flow_action_drop)(void); void *(*dr_create_flow_action_push_vlan) (struct mlx5dv_dr_domain *domain, rte_be32_t vlan_tag); - void *(*dr_create_flow_action_pop_vlan)(); + void *(*dr_create_flow_action_pop_vlan)(void); void *(*dr_create_flow_tbl)(void *domain, uint32_t level); int (*dr_destroy_flow_tbl)(void *tbl); void *(*dr_create_domain)(struct ibv_context *ctx, -- 2.26.2