From: Ruifeng Wang <ruifeng.wang@arm.com>
To: Ruifeng Wang <ruifeng.wang@arm.com>
Cc: akhil.goyal@nxp.com, david.marchand@redhat.com, dev@dpdk.org,
honnappa.nagarahalli@arm.com, nd@arm.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2 2/3] crypto/armv8: use dedicated log type
Date: Tue, 28 Jul 2020 17:24:05 +0800 [thread overview]
Message-ID: <20200728092406.9259-3-ruifeng.wang@arm.com> (raw)
In-Reply-To: <20200728092406.9259-1-ruifeng.wang@arm.com>
armv8 crypto PMD used CRYPTODEV general log type.
Create a dedicated log type for the PMD to not pollute CRYPTODEV log type.
Typo in crypto dev name macro caused unexpected device name in log.
Fixed the typo to log with correct device name.
Fixes: 169ca3db550c ("crypto/armv8: add PMD optimized for ARMv8 processors")
Cc: stable@dpdk.org
Suggested-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
drivers/crypto/armv8/armv8_pmd_private.h | 23 ++++++++++++++---------
drivers/crypto/armv8/rte_armv8_pmd.c | 2 ++
2 files changed, 16 insertions(+), 9 deletions(-)
diff --git a/drivers/crypto/armv8/armv8_pmd_private.h b/drivers/crypto/armv8/armv8_pmd_private.h
index 19940809b..709b3d536 100644
--- a/drivers/crypto/armv8/armv8_pmd_private.h
+++ b/drivers/crypto/armv8/armv8_pmd_private.h
@@ -10,19 +10,24 @@
#define CRYPTODEV_NAME_ARMV8_PMD crypto_armv8
/**< ARMv8 Crypto PMD device name */
-#define ARMV8_CRYPTO_LOG_ERR(fmt, args...) \
- RTE_LOG(ERR, CRYPTODEV, "[%s] %s() line %u: " fmt "\n", \
- RTE_STR(CRYPTODEV_NAME_ARMV8_CRYPTO_PMD), \
+extern int crypto_armv8_log_type;
+
+#define ARMV8_CRYPTO_LOG_ERR(fmt, args...) \
+ rte_log(RTE_LOG_ERR, crypto_armv8_log_type, \
+ "[%s] %s() line %u: " fmt "\n", \
+ RTE_STR(CRYPTODEV_NAME_ARMV8_PMD), \
__func__, __LINE__, ## args)
-#define ARMV8_CRYPTO_LOG_INFO(fmt, args...) \
- RTE_LOG(INFO, CRYPTODEV, "[%s] %s() line %u: " fmt "\n", \
- RTE_STR(CRYPTODEV_NAME_ARMV8_CRYPTO_PMD), \
+#define ARMV8_CRYPTO_LOG_INFO(fmt, args...) \
+ rte_log(RTE_LOG_INFO, crypto_armv8_log_type, \
+ "[%s] %s() line %u: " fmt "\n", \
+ RTE_STR(CRYPTODEV_NAME_ARMV8_PMD), \
__func__, __LINE__, ## args)
-#define ARMV8_CRYPTO_LOG_DBG(fmt, args...) \
- RTE_LOG(DEBUG, CRYPTODEV, "[%s] %s() line %u: " fmt "\n", \
- RTE_STR(CRYPTODEV_NAME_ARMV8_CRYPTO_PMD), \
+#define ARMV8_CRYPTO_LOG_DBG(fmt, args...) \
+ rte_log(RTE_LOG_DEBUG, crypto_armv8_log_type, \
+ "[%s] %s() line %u: " fmt "\n", \
+ RTE_STR(CRYPTODEV_NAME_ARMV8_PMD), \
__func__, __LINE__, ## args)
#define ARMV8_CRYPTO_ASSERT(con) \
diff --git a/drivers/crypto/armv8/rte_armv8_pmd.c b/drivers/crypto/armv8/rte_armv8_pmd.c
index 8b212772f..a2b08d818 100644
--- a/drivers/crypto/armv8/rte_armv8_pmd.c
+++ b/drivers/crypto/armv8/rte_armv8_pmd.c
@@ -861,6 +861,8 @@ static struct rte_vdev_driver armv8_crypto_pmd_drv = {
static struct cryptodev_driver armv8_crypto_drv;
+RTE_LOG_REGISTER(crypto_armv8_log_type, pmd.crypto.armv8, ERR);
+
RTE_PMD_REGISTER_VDEV(CRYPTODEV_NAME_ARMV8_PMD, armv8_crypto_pmd_drv);
RTE_PMD_REGISTER_ALIAS(CRYPTODEV_NAME_ARMV8_PMD, cryptodev_armv8_pmd);
RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_ARMV8_PMD,
--
2.17.1
next prev parent reply other threads:[~2020-07-28 9:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 8:58 [dpdk-dev] [PATCH] crypto/armv8: fix typos and compilation Ruifeng Wang
2020-07-27 9:38 ` David Marchand
2020-07-27 10:03 ` Ruifeng Wang
2020-07-28 9:24 ` [dpdk-dev] [PATCH v2 0/3] armv8 crypto PMD Ruifeng Wang
2020-07-28 9:24 ` [dpdk-dev] [PATCH v2 1/3] crypto/armv8: remove log debug option Ruifeng Wang
2020-07-28 19:48 ` Akhil Goyal
2020-07-28 9:24 ` Ruifeng Wang [this message]
2020-07-28 19:48 ` [dpdk-dev] [PATCH v2 2/3] crypto/armv8: use dedicated log type Akhil Goyal
2020-07-28 9:24 ` [dpdk-dev] [PATCH v2 3/3] crypto/armv8: remove redundant assert definition Ruifeng Wang
2020-07-28 19:49 ` Akhil Goyal
2020-07-28 20:04 ` [dpdk-dev] [PATCH v2 0/3] armv8 crypto PMD Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728092406.9259-3-ruifeng.wang@arm.com \
--to=ruifeng.wang@arm.com \
--cc=akhil.goyal@nxp.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).