From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 60D1FA052B;
	Tue, 28 Jul 2020 19:23:54 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 453DC2B8D;
	Tue, 28 Jul 2020 19:23:54 +0200 (CEST)
Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com
 [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 3AD3010A3
 for <dev@dpdk.org>; Tue, 28 Jul 2020 19:23:53 +0200 (CEST)
Received: by mail-pl1-f195.google.com with SMTP id m16so10228892pls.5
 for <dev@dpdk.org>; Tue, 28 Jul 2020 10:23:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=F+x/C56ff+ZcuSFe16lsbioI/Xx39Sf8ZOytqIsDtNA=;
 b=dEuO7jlzmmwEkrNgNqRrD2eeL3DPp92EKv9m5SYY1SgIcxrTdErLPZYPCdzpftcYAH
 rN3YBuUHMN19aTGdRJZItgRpOc20nP3qdfHyI4qn9Q8dPTW5gJoG+a6TZx6BGIwesT83
 8e6uGwMntsRTFiNs6ik7+jgMC/TVhVGbjYKF6AVHQ/x4g/XyXkldNP9vOHzldnUy19Xt
 PnrSThugbBCTfpJ9SdQJNs+3uqwQEVXl5lMJwwoCGugIBHECCzPypDdmPXpjU/g7OgGx
 tjy44MT4XVxjY59+PVJvpo41qGhOZsGvmcjVzP2v62E1BY96IcoFltuhJDBS8N/20+rW
 oESQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=F+x/C56ff+ZcuSFe16lsbioI/Xx39Sf8ZOytqIsDtNA=;
 b=ByZX+sKAZjihgo9zns9Yu6fsRrRd+T/AaXyduRUmM/9zmGKo2TXmC1x7Sv1rLlWZ0J
 bpYa4U/qcMYG+zPLZimNTp0sXOgDLLdPYp6VSxXZQpAgcs+OjwXL/KebTyU2EcybRWwF
 l2T2HfSqFLL8IlH3P8LLJe/Ry3qFJIdBLp3SiM1Ob8LYVTIgZ5zmfDhwKiOJIDZL9ThO
 moST/LTsD/DUIG93jr5P/hQPHPK0eyHe1JlYVws0CO6NOfbwknr9tSfHdieAS3JRB52L
 cMxPeeiy8WRzJVFeC/mjCrJLXuluJEWSSGmLI74kIgD/2Y/LCxcxMA4MFSo57WNRPVeB
 eTpQ==
X-Gm-Message-State: AOAM532m6at9smd+nKhF3VzzTjWLLUIDs1D2h48SNKkJ3toc5aDd3Lmz
 fwn440prZifcDEbKPqqoMEucXxUbE4kOaw==
X-Google-Smtp-Source: ABdhPJz60Bk80YJMlgPqQHhq1dbiNLHsUEK0BP0EPahsFrCwD6PB6zXqiMQd6tsPlD6fgML3Sit6rQ==
X-Received: by 2002:a17:90b:46d7:: with SMTP id
 jx23mr5856817pjb.191.1595957032291; 
 Tue, 28 Jul 2020 10:23:52 -0700 (PDT)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id l22sm3463961pjy.31.2020.07.28.10.23.51
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 28 Jul 2020 10:23:52 -0700 (PDT)
Date: Tue, 28 Jul 2020 10:23:48 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: rohit.raj@nxp.com
Cc: Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
 dev@dpdk.org
Message-ID: <20200728102348.6f130454@hermes.lan>
In-Reply-To: <20200728164252.2000-1-rohit.raj@nxp.com>
References: <20200728164252.2000-1-rohit.raj@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v1 1/3] eal: add API for bus close
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 28 Jul 2020 22:12:50 +0530
rohit.raj@nxp.com wrote:

> From: Rohit Raj <rohit.raj@nxp.com>
> 
> As per the current code we have API for bus probe, but the
> bus close API is missing. This breaks the multi process
> scenarios as objects are not cleaned while terminating the
> secondary processes.
> 
> This patch adds a new API rte_bus_close() for cleanup of
> bus objects which were acquired during probe.
> 
> Signed-off-by: Rohit Raj <rohit.raj@nxp.com>
> ---
>  lib/librte_eal/common/eal_common_bus.c | 34 +++++++++++++++++++++++++-
>  lib/librte_eal/include/rte_bus.h       | 25 ++++++++++++++++++-
>  lib/librte_eal/rte_eal_version.map     |  3 +++
>  3 files changed, 60 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c
> index baa5b532a..4c8c7eecc 100644
> --- a/lib/librte_eal/common/eal_common_bus.c
> +++ b/lib/librte_eal/common/eal_common_bus.c
> @@ -1,5 +1,5 @@
>  /* SPDX-License-Identifier: BSD-3-Clause
> - * Copyright 2016 NXP
> + * Copyright 2016,2020 NXP
>   */
>  
>  #include <stdio.h>
> @@ -56,6 +56,38 @@ rte_bus_scan(void)
>  	return 0;
>  }
>  
> +int
> +rte_bus_close(void)
> +{
> +	int ret;
> +	struct rte_bus *bus, *vbus = NULL;
> +
> +	TAILQ_FOREACH(bus, &rte_bus_list, next) {
> +		if (!strcmp(bus->name, "vdev")) {
> +			vbus = bus;
> +			continue;
> +		}
> +
> +		if (bus->close) {
> +			ret = bus->close();
> +			if (ret)
> +				RTE_LOG(ERR, EAL, "Bus (%s) close failed.\n",
> +					bus->name);
> +		}
> +	}
> +
> +	if (vbus) {
> +		if (vbus->close) {
> +			ret = vbus->close();
> +			if (ret)
> +				RTE_LOG(ERR, EAL, "Bus (%s) close failed.\n",
> +					vbus->name);
> +		}
> +	}
> +
> +	return 0;
> +}
> +
>  /* Probe all devices of all buses */
>  int
>  rte_bus_probe(void)
> diff --git a/lib/librte_eal/include/rte_bus.h b/lib/librte_eal/include/rte_bus.h
> index d3034d0ed..af4787b18 100644
> --- a/lib/librte_eal/include/rte_bus.h
> +++ b/lib/librte_eal/include/rte_bus.h
> @@ -1,5 +1,5 @@
>  /* SPDX-License-Identifier: BSD-3-Clause
> - * Copyright 2016 NXP
> + * Copyright 2016,2020 NXP
>   */
>  
>  #ifndef _RTE_BUS_H_
> @@ -67,6 +67,18 @@ typedef int (*rte_bus_scan_t)(void);
>   */
>  typedef int (*rte_bus_probe_t)(void);
>  
> +/**
> + * Implementation specific close function which is responsible for closing
> + * devices on that bus.
> + *
> + * This is called while iterating over each registered bus.
> + *
> + * @return
> + *	0 for successful close
> + *	!0 for any error while closing
> + */
> +typedef int (*rte_bus_close_t)(void);
> +
>  /**
>   * Device iterator to find a device on a bus.
>   *
> @@ -248,6 +260,7 @@ struct rte_bus {
>  	const char *name;            /**< Name of the bus */
>  	rte_bus_scan_t scan;         /**< Scan for devices attached to bus */
>  	rte_bus_probe_t probe;       /**< Probe devices on bus */
> +	rte_bus_close_t close;       /**< Close devices on bus */
>  	rte_bus_find_device_t find_device; /**< Find a device on the bus */
>  	rte_bus_plug_t plug;         /**< Probe single device for drivers */
>  	rte_bus_unplug_t unplug;     /**< Remove single device from driver */
> @@ -301,6 +314,16 @@ int rte_bus_scan(void);
>   */
>  int rte_bus_probe(void);
>  
> +/**
> + * For each device on the buses, call the device specific close.
> + *
> + * @return
> + *	 0 for successful close
> + *	!0 otherwise
> + */
> +__rte_experimental
> +int rte_bus_close(void);
> +
>  /**
>   * Dump information of all the buses registered with EAL.
>   *
> diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> index bf0c17c23..6a6d993a1 100644
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -403,6 +403,9 @@ EXPERIMENTAL {
>  	rte_mp_disable;
>  	rte_thread_register;
>  	rte_thread_unregister;
> +
> +	# added in 20.11
> +	rte_bus_close;
>  };
>  
>  INTERNAL {

This be called in the rte_eal_cleanup path?