From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBE75A052B; Tue, 28 Jul 2020 19:11:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 966EE1C002; Tue, 28 Jul 2020 19:11:36 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 4076D1BFFE for ; Tue, 28 Jul 2020 19:11:35 +0200 (CEST) IronPort-SDR: irBuDmhdANK60sC+KQToWJRaDg0ZvSb+0a4aD8nDBpZe4sHYHSb5VT6I4dXnLSGwR6nY34YOTS j/D22l2of0Ow== X-IronPort-AV: E=McAfee;i="6000,8403,9696"; a="150437527" X-IronPort-AV: E=Sophos;i="5.75,406,1589266800"; d="scan'208";a="150437527" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2020 10:11:33 -0700 IronPort-SDR: TR3Kd+TF/S7KIwc/Oaobw45z5qS4lhPdPRk+UYZ2IQrUpFEtKQ3mnvweFkQTfyol2scnxPhqoC mOMRHVJThTJQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,406,1589266800"; d="scan'208";a="320461472" Received: from dpdk-yyzhang2.sh.intel.com ([10.67.117.186]) by orsmga008.jf.intel.com with ESMTP; 28 Jul 2020 10:11:30 -0700 From: Yuying Zhang To: dev@dpdk.org, olivier.matz@6wind.com, qi.z.zhang@intel.com, qiming.yang@intel.com Cc: Yuying Zhang Date: Tue, 28 Jul 2020 17:09:50 +0000 Message-Id: <20200728170950.208532-1-yuying.zhang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200728085531.204296-1-yuying.zhang@intel.com> References: <20200728085531.204296-1-yuying.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 1/1] net: fix TSO packets checksum incorrect X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The ol_flags check lacks of flag for IPv6 which causes checksum flag configuration error while IPv6/TCP TSO packet is sent. This patch fixes the issue by adding PKT_TX_TCP_SEG flag. Fixes: 520059a41aa9 ("net: check fragmented headers in non-debug as well") Signed-off-by: Yuying Zhang --- lib/librte_net/rte_net.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_net/rte_net.h b/lib/librte_net/rte_net.h index 1edc283a4..94b06d9ee 100644 --- a/lib/librte_net/rte_net.h +++ b/lib/librte_net/rte_net.h @@ -125,7 +125,7 @@ rte_net_intel_cksum_flags_prepare(struct rte_mbuf *m, uint64_t ol_flags) * Mainly it is required to avoid fragmented headers check if * no offloads are requested. */ - if (!(ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK))) + if (!(ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK | PKT_TX_TCP_SEG))) return 0; if (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6)) -- 2.25.1