From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4098AA052B;
	Wed, 29 Jul 2020 03:01:57 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 801CB37B7;
	Wed, 29 Jul 2020 03:01:56 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by dpdk.org (Postfix) with ESMTP id 41711F04
 for <dev@dpdk.org>; Wed, 29 Jul 2020 03:01:55 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1059)
 id 687DD20B4908; Tue, 28 Jul 2020 18:01:54 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 687DD20B4908
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1595984514;
 bh=LIOFty5LfHzMpJKfoQI/MPR1MupT/fQU6OsvFDZQOpU=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=rQdUU9mOXmLJRdHYX1CrmyG62rrX4czBXEhCk6E6dKBKCL4REywgKpebCg+Jmd/Fn
 gvBpRWlGgB0Tcau3tqxkN3T6t01oWumZVC1fmuczV8dCMDcYV6758r04Th6S+DWPCR
 bEREF2YYRcnO44iMEk2XNYk9sB9IU+9Km68t9uAE=
Date: Tue, 28 Jul 2020 18:01:54 -0700
From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: Fady Bader <fady@mellanox.com>
Cc: dev@dpdk.org, thomas@monjalon.net, tbashar@mellanox.com,
 talshn@mellanox.com, yohadt@mellanox.com, dmitry.kozliuk@gmail.com,
 harini.ramakrishnan@microsoft.com, ocardona@microsoft.com,
 ranjit.menon@intel.com, pallavi.kadam@intel.com,
 kevin.laatz@intel.com, ferruh.yigit@intel.com, arybchenko@solarflare.com
Message-ID: <20200729010154.GA42791@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20200625133038.25180-1-fady@mellanox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200625133038.25180-1-fady@mellanox.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH 0/5] compiling ethdev lib under windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jun 25, 2020 at 04:30:33PM +0300, Fady Bader wrote:
> Added needed changes in order to get ethdev compiling under windows.
> 
> Depends-on: series-10382 ("compile librte_net for windows")
> 
> Fady Bader (5):
>   eal: added interrupts empty stubs
>   eal: updated export list for Windows
>   ethdev: remove structs from export list
>   telemetry: implement empty stubs for Windows
>   ethdev: compiling ethdev under Windows
> 
>  lib/librte_eal/rte_eal_exports.def       | 10 ++++++++
>  lib/librte_eal/windows/eal_interrupts.c  | 17 +++++++++++++
>  lib/librte_eal/windows/meson.build       |  1 +
>  lib/librte_ethdev/rte_ethdev_version.map |  2 --
>  lib/librte_telemetry/rte_telemetry.h     |  4 +++
>  lib/librte_telemetry/telemetry.c         | 43 +++++++++++++++++++++++++++++++-
>  lib/librte_telemetry/telemetry_legacy.c  | 26 ++++++++++++++++++-
>  lib/meson.build                          |  7 ++++--
>  8 files changed, 104 insertions(+), 6 deletions(-)
>  create mode 100644 lib/librte_eal/windows/eal_interrupts.c
> 
Tested-by: Narcisa Vasile <navasile@linux.microsoft.com>

Compiled successfully with mingw and clang. It does need a rebase, as more changes have been added in telemetry.
Also, there's a missing export that needs to be added as well 'rte_log_register_type_and_pick_level' 


> -- 
> 2.16.1.windows.4