From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 2401BA052B;
Wed, 29 Jul 2020 08:31:49 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 097E41C02E;
Wed, 29 Jul 2020 08:31:45 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
by dpdk.org (Postfix) with ESMTP id 9E1C71C023;
Wed, 29 Jul 2020 08:31:43 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 24D561FB;
Tue, 28 Jul 2020 23:31:43 -0700 (PDT)
Received: from net-arm-n1sdp.shanghai.arm.com (net-arm-n1sdp.shanghai.arm.com
[10.169.208.213])
by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8764C3F71F;
Tue, 28 Jul 2020 23:31:40 -0700 (PDT)
From: Feifei Wang <feifei.wang2@arm.com>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Gavin Hu <gavin.hu@arm.com>, Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, nd@arm.com, Feifei Wang <feifei.wang2@arm.com>,
stable@dpdk.org
Date: Wed, 29 Jul 2020 01:31:05 -0500
Message-Id: <20200729063105.11299-3-feifei.wang2@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20200729063105.11299-1-feifei.wang2@arm.com>
References: <20200729063105.11299-1-feifei.wang2@arm.com>
Subject: [dpdk-dev] [PATCH v1 2/2] test/ring: fix wrong param passed to the
enqueue APIs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
When enqueue one element (object of type void*) to ring in the
performance test, a pointer (the object to be enqueued) should be
passed to rte_ring_[sp|mp]enqueue APIs, not the pointer to a table
of void *pointers (objects).
Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests")
Cc: honnappa.nagarahalli@arm.com
Cc: stable@dpdk.org
Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
app/test/test_ring.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/test/test_ring.h b/app/test/test_ring.h
index aa6ae67ca..d4b15af7c 100644
--- a/app/test/test_ring.h
+++ b/app/test/test_ring.h
@@ -50,11 +50,11 @@ test_ring_enqueue(struct rte_ring *r, void **obj, int esize, unsigned int n,
if ((esize) == -1)
switch (api_type) {
case (TEST_RING_THREAD_DEF | TEST_RING_ELEM_SINGLE):
- return rte_ring_enqueue(r, obj);
+ return rte_ring_enqueue(r, *obj);
case (TEST_RING_THREAD_SPSC | TEST_RING_ELEM_SINGLE):
- return rte_ring_sp_enqueue(r, obj);
+ return rte_ring_sp_enqueue(r, *obj);
case (TEST_RING_THREAD_MPMC | TEST_RING_ELEM_SINGLE):
- return rte_ring_mp_enqueue(r, obj);
+ return rte_ring_mp_enqueue(r, *obj);
case (TEST_RING_THREAD_DEF | TEST_RING_ELEM_BULK):
return rte_ring_enqueue_bulk(r, obj, n, NULL);
case (TEST_RING_THREAD_SPSC | TEST_RING_ELEM_BULK):
--
2.17.1