From: Haiyue Wang <haiyue.wang@intel.com>
To: dev@dpdk.org, qiming.yang@intel.com, qi.z.zhang@intel.com
Cc: yinan.wang@intel.com, ting.xu@intel.com,
Haiyue Wang <haiyue.wang@intel.com>,
stable@dpdk.org
Subject: [dpdk-dev] [PATCH v1] net/ice: calculate TCP header size for offload
Date: Wed, 29 Jul 2020 15:50:39 +0800 [thread overview]
Message-ID: <20200729075039.336729-1-haiyue.wang@intel.com> (raw)
The ice needs the exact TCP header size including options for TCP
checksum offload, but according to PKT_TX_TCP_CKSUM note, l4_len
is not required to be set, so it needs to calculate the TCP header
size if not set.
Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
Cc: stable@dpdk.org
Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
drivers/net/ice/ice_rxtx.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index ddf6a93fb2..bcb67ec251 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -2371,6 +2371,28 @@ ice_calc_pkt_desc(struct rte_mbuf *tx_pkt)
return count;
}
+/* Calculate TCP header length for PKT_TX_TCP_CKSUM if not provided */
+static inline uint16_t
+ice_calc_pkt_tcp_hdr(struct rte_mbuf *tx_pkt, union ice_tx_offload tx_offload)
+{
+ uint16_t tcpoff = tx_offload.l2_len + tx_offload.l3_len;
+ const struct rte_tcp_hdr *tcp_hdr;
+ struct rte_tcp_hdr _tcp_hdr;
+
+ if (tcpoff + sizeof(struct rte_tcp_hdr) < tx_pkt->data_len) {
+ tcp_hdr = rte_pktmbuf_mtod_offset(tx_pkt, struct rte_tcp_hdr *,
+ tcpoff);
+
+ return (tcp_hdr->data_off & 0xf0) >> 2;
+ }
+
+ tcp_hdr = rte_pktmbuf_read(tx_pkt, tcpoff, sizeof(_tcp_hdr), &_tcp_hdr);
+ if (tcp_hdr)
+ return (tcp_hdr->data_off & 0xf0) >> 2;
+ else
+ return 0;
+}
+
uint16_t
ice_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
{
@@ -2468,6 +2490,11 @@ ice_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
/* Enable checksum offloading */
if (ol_flags & ICE_TX_CKSUM_OFFLOAD_MASK) {
+ if ((ol_flags & PKT_TX_L4_MASK) == PKT_TX_TCP_CKSUM &&
+ !tx_offload.l4_len)
+ tx_offload.l4_len =
+ ice_calc_pkt_tcp_hdr(tx_pkt, tx_offload);
+
ice_txd_enable_checksum(ol_flags, &td_cmd,
&td_offset, tx_offload);
}
--
2.28.0
next reply other threads:[~2020-07-29 8:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 7:50 Haiyue Wang [this message]
2020-07-29 8:08 ` Zhang, Qi Z
2020-07-29 10:48 ` Yang, Qiming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729075039.336729-1-haiyue.wang@intel.com \
--to=haiyue.wang@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=ting.xu@intel.com \
--cc=yinan.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).