From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 46C2DA052B;
	Fri, 31 Jul 2020 17:46:44 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 78D30262E;
	Fri, 31 Jul 2020 17:46:43 +0200 (CEST)
Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com
 [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 7EEDE10A3
 for <dev@dpdk.org>; Fri, 31 Jul 2020 17:46:42 +0200 (CEST)
Received: by mail-pf1-f196.google.com with SMTP id w126so14505522pfw.8
 for <dev@dpdk.org>; Fri, 31 Jul 2020 08:46:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=z4z3TlioFW0hWI8WXV3usenyNGtDfyUlxTwtFS79y7A=;
 b=k56yp+OfBnl/svr+IMc4uKrBE68D6Xg0JhPJF2ooHn8SzHXcimfkoNMNFlVaKg9XIa
 WG2lS7/T9nWa8Vyr0Bm2QQFUvKvfi1IUhhZVFhOK4le+JKkjvHCrwrWpazHt5V52uo8R
 y6WJksXQ7Ak0PKmFpcpJU4DAimtTO+z61RjXGfi8nsmfbnvDhUtFl3c0cRsdmFlGtcLJ
 Wsg0hHcUcTF64G47OQlkBOCP1ozGSNuLTp5mJF46jEgGEWW4ySlvW3n7qD1Yz9zqkoz+
 gWhwnD38SVhrOvGFozAj1BbTDegg0Ubyj5ND2K3v8tV2ArcED9cU4oM6v7A+k+Y3ns1P
 SL3Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=z4z3TlioFW0hWI8WXV3usenyNGtDfyUlxTwtFS79y7A=;
 b=dmcIDn1WNAK1VxQ8V1pDxNjmembqpotjOEawawu9GqBFwheUW7G6LxsAqIXVBVmeun
 ARBOztm1d6KKrYp+xp+Bp3U6P+69CHKtJ+w8HyZBQELlwg6JrDTUtPqc6cYqd8qN7cr9
 AvRBeKYumMYq/EaNGRHQ0Jz0xHqS1/fx7G2tB1Xt9RZk9PrO3WcJCRXv/tqSSc1H0vd2
 y4fa0sE4i1BekE9D2isriUx5mZgUBBY6ZpuqutdkAbgJFUTqL14M9TchsWKYU6X+aIai
 CZa4m0+YDjwmBNbVqnS57KknwXBci0AvDjrKnrgjn+OzjIJ8jMI8HyJdFsjUCgsq2pgh
 Ir0Q==
X-Gm-Message-State: AOAM531hQmTKMQNvWcaTU0HC1h8NawwtHRRdmwWSE2BuemFxR90h+1xZ
 4cVkwInv0jldAO5rUR9L6J755w==
X-Google-Smtp-Source: ABdhPJwSE1MmLYr/zZNHiyGFZjpu1d7KON+NdD/xsnbctB1ffYXAvWdAcg/A0obkDzJ6MO6wQHk70w==
X-Received: by 2002:a65:4502:: with SMTP id n2mr4290868pgq.132.1596210401461; 
 Fri, 31 Jul 2020 08:46:41 -0700 (PDT)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id f29sm11083537pga.59.2020.07.31.08.46.40
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 31 Jul 2020 08:46:41 -0700 (PDT)
Date: Fri, 31 Jul 2020 08:46:38 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: David Marchand <david.marchand@redhat.com>, Wisam Jaddo
 <wisamm@mellanox.com>, dev <dev@dpdk.org>, Raslan <rasland@mellanox.com>,
 Thomas Monjalon <thomas@monjalon.net>, "Iremonger, Bernard"
 <bernard.iremonger@intel.com>, dpdk stable <stable@dpdk.org>
Message-ID: <20200731084638.304ef20c@hermes.lan>
In-Reply-To: <20200731125516.GG5869@platinum>
References: <1582204709-7992-1-git-send-email-wisamm@mellanox.com>
 <1582210386-27331-1-git-send-email-wisamm@mellanox.com>
 <CAJFAV8x7HwFAiz9nw=zQ1t7ZzSwbJCuQGKf0XTv3o4SEU4y6mw@mail.gmail.com>
 <20200731125516.GG5869@platinum>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3] cmdline: increase maximum line length
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 31 Jul 2020 14:55:16 +0200
Olivier Matz <olivier.matz@6wind.com> wrote:

> Hi,
> 
> Ressurecting this old thread.
> 
> On Sat, Feb 22, 2020 at 04:28:15PM +0100, David Marchand wrote:
> > This patch is flagged as an ABI breakage:
> > https://travis-ci.com/ovsrobot/dpdk/jobs/289313318#L2273
> >   
> 
> In case we want this fix for 20.11, should we do a deprecation notice
> in 20.08?
> 
> 
> Olivier
> 
> 
> > 
> > On Thu, Feb 20, 2020 at 3:53 PM Wisam Jaddo <wisamm@mellanox.com> wrote:  
> > >
> > > This increase due to the usage of cmdline in dpdk applications
> > > as config commands such as testpmd do for rte_flow rules creation.
> > >
> > > The current size of buffer is not enough to fill
> > > many cases of rte_flow commands validation/creation.
> > >
> > > rte_flow now can have outer items, inner items, modify
> > > actions, meta data actions, duplicate action, fate action and
> > > more in one single rte flow, thus 512 char will not be enough
> > > to validate such rte flow rules.
> > >
> > > Such change shouldn't affect the memory since the cmdline
> > > reading again using the same buffer.  
> > 
> > I don't get your point here.

The cmdline is a awkward user API. Thomas wanted to replace it but
it seems to have gotten nowhere.

Agree that having something dynamic would be best, Something
based of getline() or editline (readline).