DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: announce API change in timer
@ 2020-08-03 11:20 Sarosh Arif
  2020-08-03 16:45 ` Carrillo, Erik G
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Sarosh Arif @ 2020-08-03 11:20 UTC (permalink / raw)
  To: erik.g.carrillo, rsanford; +Cc: dev, Sarosh Arif

If the user tries to reset/stop some other timer in it's callback
function, which is also about to expire, using 
rte_timer_reset_sync/rte_timer_stop_sync the application goes into
an infinite loop. This happens because 
rte_timer_reset_sync/rte_timer_stop_sync loop until the timer 
resets/stops and there is check inside timer_set_config_state which
prevents a running timer from being reset/stopped by not it's own 
timer_cb. Therefore timer_set_config_state returns -1 due to which 
rte_timer_reset returns -1 and rte_timer_reset_sync goes into an 
infinite loop

To to prevent this rte_timer_reset_sync and rte_timer_stop_sync should
have int return types, so that -1 can be returned if the above condition
occurs

Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
---
 doc/guides/rel_notes/deprecation.rst | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index ea4cfa7a4..ed93a707d 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -151,3 +151,9 @@ Deprecation Notices
   Python 2 support will be completely removed in 20.11.
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
+
+* timer: Since timer can get stuck in an infinite loop if the application tries to
+  reset/stop some other timer in it's callback function, which is also about to
+  expire. The function ``rte_timer_stop_sync`` and ``rte_timer_stop_sync``  will
+  have a int return type in order to return with -1 in when this condition
+  occures.
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-08-04 20:50 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-03 11:20 [dpdk-dev] [PATCH] doc: announce API change in timer Sarosh Arif
2020-08-03 16:45 ` Carrillo, Erik G
2020-08-03 23:16 ` Honnappa Nagarahalli
2020-08-04  3:28   ` Sarosh Arif
2020-08-04 14:24     ` Carrillo, Erik G
2020-08-04 20:50       ` Honnappa Nagarahalli
2020-08-04  3:51 ` [dpdk-dev] [PATCH v2] " Sarosh Arif

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git