From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A77F2A053A; Tue, 4 Aug 2020 11:48:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4CFDC1C00D; Tue, 4 Aug 2020 11:48:16 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 2177729D2 for ; Tue, 4 Aug 2020 11:48:15 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id D75921722; Tue, 4 Aug 2020 05:48:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 04 Aug 2020 05:48:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=nR54IW8zF0FAM gn4fMynXalFOs7rFGvMrrfLEdWSTAU=; b=eBxB/M4O2fNh59+AunxZz/Vpa5Mak OWLwVa6rpRuk5G/0UEM/zcUdddMGIcJAmU+n5OnVqdbL0m2R+MblEGFqoLEpL9SH ZWv5q4jjjNdGnoT/BlshAlx36ESB8SJbK/hldUVgfheLOQNJKx1i1r4OZN7QP/DU dOixKI958Uhhc5ADDkTRY/aGSHig9CYgpSGoBvWdDHK5xPe0sDJDRH5qg12qMlwS zxCfMr7rYYSoWiyoCEsDbcrw13XwK+diTcqma5Ylhl/3gpSn4PWbsJK+JVHmNnrc rf+BQIY3V9so4gMdry+vgEInEnFG1ip5WX+5UCP15f+ESYyqMx+h+H7MQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=nR54IW8zF0FAMgn4fMynXalFOs7rFGvMrrfLEdWSTAU=; b=G7apzAkv v8aScRtw4Ph0xAEHuFBVDncjNcvAZws5rUAUi0/uZaVrwy0KFOkxEZORtkf+sOrX XkF4Ps6LB53q5lXJXkctpz4PBWCXQwQGjk75TJT4w37SQYmTJXOb+dTAoNUkT8kS ZixsD7KZP9Mkl3aUAOBkgD5mmWl98uFwvZT3cJLn2SAJHfqZXfBPxspv0XzQ4wQp O01GSt64xgVyCF26RtEo4hnoASJuUW/Tfa0AZpCGMky5SeShIs1Jbbhe+88y+cXU uABFSJEJzOwZsedOjODeF9bBHEaoPlf5HCoDsYcJphQKrDGD05V+KtHPzNwDkCds LZ2rJky6+7gQMw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeeigddvtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedvhefgiedvjeegtdevheefhfetleefgfeivefgffevfeejgedtgfeu tdehtdegveenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B2B953060067; Tue, 4 Aug 2020 05:48:12 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: Ferruh Yigit , Andrew Rybchenko Date: Tue, 4 Aug 2020 11:48:08 +0200 Message-Id: <20200804094808.3339810-1-thomas@monjalon.net> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200804094120.3338635-1-thomas@monjalon.net> References: <20200804094120.3338635-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2] ethdev: remove device-specific comments from VLAN API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Some confusing comments were still present from old days, when most drivers were from Intel. Signed-off-by: Thomas Monjalon --- v2: remove i40e comment for pvid field --- lib/librte_ethdev/rte_ethdev.h | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 57e4a6ca58..d29930fd84 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -924,7 +924,6 @@ struct rte_eth_txmode { */ uint64_t offloads; - /* For i40e specifically */ uint16_t pvid; __extension__ uint8_t hw_vlan_reject_tagged : 1, @@ -2846,7 +2845,6 @@ int rte_eth_dev_vlan_filter(uint16_t port_id, uint16_t vlan_id, int on); /** * Enable/Disable hardware VLAN Strip by a rx queue of an Ethernet device. - * 82599/X540/X550 can support VLAN stripping at the rx queue level * * @param port_id * The port identifier of the Ethernet device. @@ -2868,8 +2866,7 @@ int rte_eth_dev_set_vlan_strip_on_queue(uint16_t port_id, uint16_t rx_queue_id, /** * Set the Outer VLAN Ether Type by an Ethernet device, it can be inserted to - * the VLAN Header. This is a register setup available on some Intel NIC, not - * but all, please check the data sheet for availability. + * the VLAN header. * * @param port_id * The port identifier of the Ethernet device. @@ -2888,12 +2885,7 @@ int rte_eth_dev_set_vlan_ether_type(uint16_t port_id, uint16_t tag_type); /** - * Set VLAN offload configuration on an Ethernet device - * Enable/Disable Extended VLAN by an Ethernet device, This is a register setup - * available on some Intel NIC, not but all, please check the data sheet for - * availability. - * Enable/Disable VLAN Strip can be done on rx queue for certain NIC, but here - * the configuration is applied on the port level. + * Set VLAN offload configuration on an Ethernet device. * * @param port_id * The port identifier of the Ethernet device. -- 2.27.0