From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 8A663A053A;
	Wed,  5 Aug 2020 01:43:51 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id DA54B1C00D;
	Wed,  5 Aug 2020 01:43:50 +0200 (CEST)
Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com
 [209.85.208.194]) by dpdk.org (Postfix) with ESMTP id B46A11BFF7
 for <dev@dpdk.org>; Wed,  5 Aug 2020 01:43:49 +0200 (CEST)
Received: by mail-lj1-f194.google.com with SMTP id v12so15239703ljc.10
 for <dev@dpdk.org>; Tue, 04 Aug 2020 16:43:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=MK/5jqcoa5RRtqHWx4wf+9Uel/63qplKCstvuK6Teao=;
 b=t1eOlckDoV/hHtKqcPPyq+vLKSr8BnHE/OHlqLdMGIr9/y5D+P+g4A+/S4Stgb8Tmm
 j0o/vtX+/cqDPriiqcSLlMmmpH42G5+7UN2HeBXeHEBo/TJWwsKfZQKSkZBxPHXpYrV7
 nd1PXFUYmrNrBjSG2ce2RIMmV/KvjdjyanWoQWfVLItXnL1Vk4+BBF+/AU5eb92yT/2R
 mTElumX8WnZgkCC+SYx3rHpOo1zpcPFwAUdSFO0m+XPaqvSDhD2854WdMoBc3CCF6yI8
 OFYb5Yy2aatKnp511bpuVST65eNjvFWQfRKnyvqI/MDMM9lG+M7owWeo7oNASt21FWuD
 Rrjg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=MK/5jqcoa5RRtqHWx4wf+9Uel/63qplKCstvuK6Teao=;
 b=G2hB2NkWumZVX6VRjFgcwLkEkDn8UjGIIX14Wkf6xUUItHmL9oom7x1VvIsBFf2JpI
 Ra8cBzikh3sXR5F7gXd03Vt2hShb0/jJfH4cnydfTGbHFwMHmnASLaCX/zjKZ3AGcJUI
 dyA3Q3w+lyyVYxixrlyy8IcZn8Z8JsNZuOJhSEZNWqXrL+qPRd59rXuRx/VVw3k+H3bJ
 50Z9lGx+mLrbi3vUO9dU7jtcDdsM180ixm44QxC30YBRJ1NE8LNQfTqpzrFPXBLJWCy1
 H0VN8+DKrk3F2zY8xCXQTRzvytr0pP6vHvFoD11gKyZjmQF20CFgYrxF8yZabodpCAX8
 dwig==
X-Gm-Message-State: AOAM531o5Lh5Go5B865Mbowqh1CznzeE46K1BPy2M5QbVhCnmZo16Qap
 dEk+tvwefCdWYOsm/fHPHKk=
X-Google-Smtp-Source: ABdhPJxKJfsb2fKlzVgWKunH11r97AfMYZlo3Z6JuWSRPygUG4zmYSQRnJBfAv+O3TPthrsdNMXTXw==
X-Received: by 2002:a2e:81c2:: with SMTP id s2mr119781ljg.10.1596584629335;
 Tue, 04 Aug 2020 16:43:49 -0700 (PDT)
Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru.
 [37.110.65.23])
 by smtp.gmail.com with ESMTPSA id d26sm231305lfq.73.2020.08.04.16.43.47
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 04 Aug 2020 16:43:48 -0700 (PDT)
Date: Wed, 5 Aug 2020 02:43:46 +0300
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Fady Bader <fady@mellanox.com>
Cc: dev@dpdk.org, thomas@monjalon.net, tbashar@mellanox.com,
 talshn@mellanox.com, yohadt@mellanox.com,
 harini.ramakrishnan@microsoft.com, ocardona@microsoft.com,
 pallavi.kadam@intel.com, ranjit.menon@intel.com, kevin.laatz@intel.com,
 ferruh.yigit@intel.com, arybchenko@solarflare.com, ciara.power@intel.com,
 navasile@linux.microsoft.com
Message-ID: <20200805024346.2289115d@sovereign>
In-Reply-To: <20200804062947.6176-2-fady@mellanox.com>
References: <20200625133038.25180-1-fady@mellanox.com>
 <20200804062947.6176-1-fady@mellanox.com>
 <20200804062947.6176-2-fady@mellanox.com>
X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4 1/5] eal: added interrupts empty stubs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue,  4 Aug 2020 09:29:43 +0300, Fady Bader wrote:
[snip]
> diff --git a/lib/librte_eal/windows/eal_interrupts.c b/lib/librte_eal/windows/eal_interrupts.c
> new file mode 100644
> index 0000000000..1e3c6d20d2
> --- /dev/null
> +++ b/lib/librte_eal/windows/eal_interrupts.c
> @@ -0,0 +1,17 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright 2020 Mellanox Technologies, Ltd
> + */

Blank line is needed here, like in other files.

> +#include <rte_interrupts.h>
[snip]
> diff --git a/lib/librte_eal/windows/meson.build b/lib/librte_eal/windows/meson.build
> index 08c888e018..c5a19648d6 100644
> --- a/lib/librte_eal/windows/meson.build
> +++ b/lib/librte_eal/windows/meson.build
> @@ -17,6 +17,7 @@ sources += files(
>  	'eal_timer.c',
>  	'fnmatch.c',
>  	'getopt.c',
> +	'eal_interrupts.c',
>  )

Please keep the list sorted.