From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56EFFA053D; Wed, 5 Aug 2020 17:07:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DF89B1B203; Wed, 5 Aug 2020 17:07:50 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 015582BB5; Wed, 5 Aug 2020 17:07:48 +0200 (CEST) IronPort-SDR: FWT458Qvqplr4BZVQL1WE/bD7xnffn+ZjjEEeOTXBSZvGV9engOrg9Wlz9HlH2r9asfguVFQAw K95lP8wuDMrw== X-IronPort-AV: E=McAfee;i="6000,8403,9703"; a="132636403" X-IronPort-AV: E=Sophos;i="5.75,438,1589266800"; d="scan'208";a="132636403" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2020 08:07:47 -0700 IronPort-SDR: 9ZPuDGt2fo5sKQylZSsV4PmwHuAiwagJGq192wUpu8UKqRmqrUQvjsJ7eJNVLCH0Z7sSnasT43 BYZyFyM1n3Xg== X-IronPort-AV: E=Sophos;i="5.75,438,1589266800"; d="scan'208";a="437200478" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.255.148]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 05 Aug 2020 08:07:44 -0700 Date: Wed, 5 Aug 2020 16:07:41 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, techboard@dpdk.org Message-ID: <20200805150741.GD1716@bricha3-MOBL.ger.corp.intel.com> References: <20200805142141.32337-1-bruce.richardson@intel.com> <20200805142141.32337-2-bruce.richardson@intel.com> <2844470.HTv9E7uqEf@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2844470.HTv9E7uqEf@thomas> Subject: Re: [dpdk-dev] [dpdk-techboard] [PATCH 1/1] doc: add deprecation notice for CPU build flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Aug 05, 2020 at 04:57:42PM +0200, Thomas Monjalon wrote: > 05/08/2020 16:21, Bruce Richardson: > > The RTE_MACHINE_CPUFLAGS_* macros in DPDK build just duplicate info from > > the compiler macros, so we can remove them and just use the compiler > > versions directly. > > > > Signed-off-by: Bruce Richardson > > --- > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > +* build macros: The macros defining RTE_MACHINE_CPUFLAG_* will be removed > > + from the build. The information provided by these macros is available > > + through standard compiler macros. For example, RTE_MACHINE_CPUFLAG_SSE3 > > + duplicates the compiler-provided macro __SSE3__. > > I see 2 advantages of having alias: > - if 2 compilers differ, we can manage > - we can find all such macros with grep RTE_MACHINE_CPUFLAG > Sure, if you think it's worthwhile keeping them, we can do so. It's just right now they seem to be largely a waste of space. For #2, I'm not sure when we would want to grep for them all, except possibly to remove them. :-)