From: Steven Lariau <steven.lariau@arm.com>
To: Gage Eads <gage.eads@intel.com>, Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, honnappa.nagarahalli@arm.com,
dharmik.thakkar@arm.com, nd@arm.com,
Steven Lariau <steven.lariau@arm.com>
Subject: [dpdk-dev] [PATCH 2/4] test/stack: launch tests with mp remote launch API
Date: Wed, 5 Aug 2020 16:57:19 +0100 [thread overview]
Message-ID: <20200805155721.19808-3-steven.lariau@arm.com> (raw)
In-Reply-To: <20200805155721.19808-1-steven.lariau@arm.com>
All the cores use the same argument object, so there is no need to use
a loop to launch the test on every core one by one.
Replace loop with one call to rte_eal_mp_remote_launch
Signed-off-by: Steven Lariau <steven.lariau@arm.com>
Reviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
Reviewed-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
app/test/test_stack.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/app/test/test_stack.c b/app/test/test_stack.c
index 5a7273a7d..c100d9faf 100644
--- a/app/test/test_stack.c
+++ b/app/test/test_stack.c
@@ -322,7 +322,6 @@ static int
test_stack_multithreaded(uint32_t flags)
{
struct test_args args;
- unsigned int lcore_id;
struct rte_stack *s;
rte_atomic64_t size;
@@ -345,14 +344,8 @@ test_stack_multithreaded(uint32_t flags)
args.s = s;
args.sz = &size;
- RTE_LCORE_FOREACH_SLAVE(lcore_id) {
- if (rte_eal_remote_launch(stack_thread_push_pop,
- &args, lcore_id))
- rte_panic("Failed to launch lcore %d\n", lcore_id);
- }
-
- stack_thread_push_pop(&args);
-
+ if (rte_eal_mp_remote_launch(stack_thread_push_pop, &args, CALL_MASTER))
+ rte_panic("Failed to launch tests\n");
rte_eal_mp_wait_lcore();
rte_stack_free(s);
--
2.17.1
next prev parent reply other threads:[~2020-08-05 15:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 15:57 [dpdk-dev] [PATCH 0/4] test/stack: improve multithreaded test Steven Lariau
2020-08-05 15:57 ` [dpdk-dev] [PATCH 1/4] test/stack: avoid trivial memory allocations Steven Lariau
2020-08-11 20:13 ` Eads, Gage
2020-08-11 20:38 ` Stephen Hemminger
2020-08-11 20:49 ` Honnappa Nagarahalli
2020-08-11 21:14 ` Eads, Gage
2020-08-05 15:57 ` Steven Lariau [this message]
2020-08-11 20:13 ` [dpdk-dev] [PATCH 2/4] test/stack: launch tests with mp remote launch API Eads, Gage
2020-08-05 15:57 ` [dpdk-dev] [PATCH 3/4] test/stack: propagate errors to main core Steven Lariau
2020-08-11 20:13 ` Eads, Gage
2020-08-05 15:57 ` [dpdk-dev] [PATCH 4/4] test/stack: remove atomics operations Steven Lariau
2020-08-11 20:13 ` Eads, Gage
2020-08-12 19:18 ` [dpdk-dev] [PATCH v2 0/4] test/stack: improve multithreaded test Steven Lariau
2020-08-12 19:18 ` [dpdk-dev] [PATCH v2 1/4] test/stack: avoid trivial memory allocations Steven Lariau
2020-08-13 21:38 ` Eads, Gage
2020-08-12 19:18 ` [dpdk-dev] [PATCH v2 2/4] test/stack: launch tests with mp remote launch API Steven Lariau
2020-08-12 19:18 ` [dpdk-dev] [PATCH v2 3/4] test/stack: propagate errors to main core Steven Lariau
2020-08-12 19:18 ` [dpdk-dev] [PATCH v2 4/4] test/stack: remove atomics operations Steven Lariau
2020-09-30 19:12 ` [dpdk-dev] [PATCH v2 0/4] test/stack: improve multithreaded test David Marchand
-- strict thread matches above, loose matches on Subject: below --
2020-08-05 15:45 [dpdk-dev] [PATCH " Steven Lariau
2020-08-05 15:45 ` [dpdk-dev] [PATCH 2/4] test/stack: launch tests with mp remote launch API Steven Lariau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805155721.19808-3-steven.lariau@arm.com \
--to=steven.lariau@arm.com \
--cc=dev@dpdk.org \
--cc=dharmik.thakkar@arm.com \
--cc=gage.eads@intel.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).