From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 3B64EA053D;
Wed, 5 Aug 2020 17:58:15 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id E06C01C0B0;
Wed, 5 Aug 2020 17:57:49 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
by dpdk.org (Postfix) with ESMTP id 916F11C039
for <dev@dpdk.org>; Wed, 5 Aug 2020 17:57:48 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 138171424;
Wed, 5 Aug 2020 08:57:48 -0700 (PDT)
Received: from localhost.localdomain (unknown [10.57.38.158])
by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 16A1A3F7D7;
Wed, 5 Aug 2020 08:57:46 -0700 (PDT)
From: Steven Lariau <steven.lariau@arm.com>
To: Gage Eads <gage.eads@intel.com>,
Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, honnappa.nagarahalli@arm.com, dharmik.thakkar@arm.com,
nd@arm.com, Steven Lariau <steven.lariau@arm.com>
Date: Wed, 5 Aug 2020 16:57:21 +0100
Message-Id: <20200805155721.19808-5-steven.lariau@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20200805155721.19808-1-steven.lariau@arm.com>
References: <20200805155721.19808-1-steven.lariau@arm.com>
Subject: [dpdk-dev] [PATCH 4/4] test/stack: remove atomics operations
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Remove the part that checks if there is enough room in the stack, it's
always true as long as size of stack >= MAX_BULK*rte_lcore_count().
This check used an atomic cmpset, and read / write to a shared size
variable. These operations result in some form of synchronization
that might get in the way of the actual stack testing.
Signed-off-by: Steven Lariau <steven.lariau@arm.com>
Reviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
Reviewed-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
app/test/test_stack.c | 23 +++--------------------
1 file changed, 3 insertions(+), 20 deletions(-)
diff --git a/app/test/test_stack.c b/app/test/test_stack.c
index b9d6befd4..02bea7ec5 100644
--- a/app/test/test_stack.c
+++ b/app/test/test_stack.c
@@ -273,7 +273,6 @@ test_free_null(void)
struct test_args {
struct rte_stack *s;
- rte_atomic64_t *sz;
};
static int
@@ -284,21 +283,9 @@ stack_thread_push_pop(void *args)
int i;
for (i = 0; i < NUM_ITERS_PER_THREAD; i++) {
- unsigned int success, num;
+ unsigned int num;
- /* Reserve up to min(MAX_BULK, available slots) stack entries,
- * then push and pop those stack entries.
- */
- do {
- uint64_t sz = rte_atomic64_read(t->sz);
- volatile uint64_t *sz_addr;
-
- sz_addr = (volatile uint64_t *)t->sz;
-
- num = RTE_MIN(rte_rand() % MAX_BULK, STACK_SIZE - sz);
-
- success = rte_atomic64_cmpset(sz_addr, sz, sz + num);
- } while (success == 0);
+ num = rte_rand() % MAX_BULK;
if (rte_stack_push(t->s, obj_table, num) != num) {
printf("[%s():%u] Failed to push %u pointers\n",
@@ -312,7 +299,6 @@ stack_thread_push_pop(void *args)
return -1;
}
- rte_atomic64_sub(t->sz, num);
}
return 0;
@@ -324,7 +310,6 @@ test_stack_multithreaded(uint32_t flags)
struct test_args args;
unsigned int lcore_id;
struct rte_stack *s;
- rte_atomic64_t size;
int result = 0;
if (rte_lcore_count() < 2) {
@@ -335,16 +320,14 @@ test_stack_multithreaded(uint32_t flags)
printf("[%s():%u] Running with %u lcores\n",
__func__, __LINE__, rte_lcore_count());
- s = rte_stack_create("test", STACK_SIZE, rte_socket_id(), flags);
+ s = rte_stack_create("test", MAX_BULK * rte_lcore_count(), rte_socket_id(), flags);
if (s == NULL) {
printf("[%s():%u] Failed to create a stack\n",
__func__, __LINE__);
return -1;
}
- rte_atomic64_init(&size);
args.s = s;
- args.sz = &size;
if (rte_eal_mp_remote_launch(stack_thread_push_pop, &args, CALL_MASTER))
rte_panic("Failed to launch tests\n");
--
2.17.1