From: Gaurav Singh <gaurav1086@gmail.com>
To: dev@dpdk.org
Cc: Gaurav Singh <gaurav1086@gmail.com>
Subject: [dpdk-dev] [PATCH] net/bnxt: remove redundant null check in bnxt_validate_and_parse_flow_type
Date: Wed, 5 Aug 2020 23:50:49 -0400 [thread overview]
Message-ID: <20200806035049.22471-1-gaurav1086@gmail.com> (raw)
In-Reply-To: <26979354.Z9mb2dG3pe@thomas>
vxlan_spec cannot be NULL since its already being accessed
before. Remove the redundant NULL check.
Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
---
drivers/net/bnxt/bnxt_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
index 320b53d94..c1c59bbe5 100644
--- a/drivers/net/bnxt/bnxt_flow.c
+++ b/drivers/net/bnxt/bnxt_flow.c
@@ -554,7 +554,7 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,
}
/* Check if VNI is masked. */
- if (vxlan_spec && vxlan_mask) {
+ if (vxlan_mask != NULL) {
vni_masked =
!!memcmp(vxlan_mask->vni, vni_mask,
RTE_DIM(vni_mask));
--
2.17.1
next prev parent reply other threads:[~2020-08-06 3:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 2:34 [dpdk-dev] [PATCH] net/bxnt: remove redundant null check Gaurav Singh
2020-07-31 5:03 ` Ajit Khaparde
2020-08-05 20:11 ` Thomas Monjalon
2020-08-06 3:50 ` Gaurav Singh [this message]
2020-08-06 3:52 ` [dpdk-dev] [PATCH] net/bnxt: remove redundant null check in bnxt_validate_and_parse_flow_type Gaurav Singh
2020-09-02 4:03 ` Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806035049.22471-1-gaurav1086@gmail.com \
--to=gaurav1086@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).