From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id BFC63A04B0;
Fri, 7 Aug 2020 18:07:55 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id E4FFD1C10C;
Fri, 7 Aug 2020 18:06:39 +0200 (CEST)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by dpdk.org (Postfix) with ESMTP id DE3E31C0D4
for <dev@dpdk.org>; Fri, 7 Aug 2020 18:06:37 +0200 (CEST)
IronPort-SDR: 2eqyev7UZd09z/cGkg0MGqrjqcAt670x82Djfk+rm/ki++T7fGMq/kfSjKASnRKiAs5z1++Fh7
CkegDRVR+tQw==
X-IronPort-AV: E=McAfee;i="6000,8403,9705"; a="171183084"
X-IronPort-AV: E=Sophos;i="5.75,446,1589266800"; d="scan'208";a="171183084"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
07 Aug 2020 09:06:37 -0700
IronPort-SDR: 9CX3/pANPYnGrexkv2IOtddqvxG2UMCF+TTEx6HALX1XXqsVEqnP6rPGQNtcVxbEshwH34BUgI
NjEbw3eNu6hw==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.75,446,1589266800"; d="scan'208";a="275407922"
Received: from silpixa00399953.ir.intel.com (HELO
silpixa00399953.ger.corp.intel.com) ([10.237.222.53])
by fmsmga007.fm.intel.com with ESMTP; 07 Aug 2020 09:06:36 -0700
From: Ciara Power <ciara.power@intel.com>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, Ciara Power <ciara.power@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>, Beilei Xing <beilei.xing@intel.com>
Date: Fri, 7 Aug 2020 16:58:55 +0100
Message-Id: <20200807155859.63888-9-ciara.power@intel.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20200807155859.63888-1-ciara.power@intel.com>
References: <20200807155859.63888-1-ciara.power@intel.com>
Subject: [dpdk-dev] [PATCH 20.11 08/12] net/iavf: add checks for max SIMD
bitwidth
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
When choosing a vector path to take, an extra condition must be
satisfied to ensure the max SIMD bitwidth allows for the CPU enabled
path.
Cc: Jingjing Wu <jingjing.wu@intel.com>
Cc: Beilei Xing <beilei.xing@intel.com>
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
drivers/net/iavf/iavf_rxtx.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index 05a7dd898a..b798d082a2 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -2105,14 +2105,16 @@ iavf_set_rx_function(struct rte_eth_dev *dev)
int i;
bool use_avx2 = false;
- if (!iavf_rx_vec_dev_check(dev)) {
+ if (!iavf_rx_vec_dev_check(dev) &&
+ rte_get_max_simd_bitwidth() >= RTE_MAX_128_SIMD) {
for (i = 0; i < dev->data->nb_rx_queues; i++) {
rxq = dev->data->rx_queues[i];
(void)iavf_rxq_vec_setup(rxq);
}
- if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 ||
- rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1)
+ if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 ||
+ rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1) &&
+ rte_get_max_simd_bitwidth() >= RTE_MAX_256_SIMD)
use_avx2 = true;
if (dev->data->scattered_rx) {
@@ -2178,7 +2180,8 @@ iavf_set_tx_function(struct rte_eth_dev *dev)
int i;
bool use_avx2 = false;
- if (!iavf_tx_vec_dev_check(dev)) {
+ if (!iavf_tx_vec_dev_check(dev) &&
+ rte_get_max_simd_bitwidth() >= RTE_MAX_128_SIMD) {
for (i = 0; i < dev->data->nb_tx_queues; i++) {
txq = dev->data->tx_queues[i];
if (!txq)
@@ -2186,8 +2189,9 @@ iavf_set_tx_function(struct rte_eth_dev *dev)
iavf_txq_vec_setup(txq);
}
- if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 ||
- rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1)
+ if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 ||
+ rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1) &&
+ rte_get_max_simd_bitwidth() >= RTE_MAX_256_SIMD)
use_avx2 = true;
PMD_DRV_LOG(DEBUG, "Using %sVector Tx (port %d).",
--
2.17.1