From: Pawel Wodkowski <pawelwod@gmail.com>
To: dev@dpdk.org
Cc: Pawel Wodkowski <pawelwod@gmail.com>,
qi.z.zhang@intel.com, Wei Zhao <wei.zhao1@intel.com>,
Jeff Guo <jia.guo@intel.com>
Subject: [dpdk-dev] [PATCH] net/ixgbe: fix fdir flows with RTE_FLOW_ITEM_TYPE_RAW
Date: Mon, 10 Aug 2020 22:31:08 +0200 [thread overview]
Message-ID: <20200810203108.28770-1-pawelwod@gmail.com> (raw)
Flows like IP4 / UDP / RAW are not working because after parsing
RTE_FLOW_ITEM_TYPE_RAW item pointer is not advanced. This make whole
parsing fail.
Fixes: f35fec63dde1 ("net/ixgbe: enable flex bytes for generic flow API")
Cc: qi.z.zhang@intel.com
Signed-off-by: Pawel Wodkowski <pawelwod@gmail.com>
---
drivers/net/ixgbe/ixgbe_flow.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
index b2a2bfc02..a2cb599b1 100644
--- a/drivers/net/ixgbe/ixgbe_flow.c
+++ b/drivers/net/ixgbe/ixgbe_flow.c
@@ -2251,6 +2251,8 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev,
(((uint16_t)raw_spec->pattern[1]) << 8) |
raw_spec->pattern[0];
rule->flex_bytes_offset = raw_spec->offset;
+
+ item = next_no_fuzzy_pattern(pattern, item);
}
if (item->type != RTE_FLOW_ITEM_TYPE_END) {
--
2.17.1
next reply other threads:[~2020-08-10 20:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 20:31 Pawel Wodkowski [this message]
2020-08-31 3:46 ` Zhang, Qi Z
2020-09-02 8:51 ` Pawel Wodkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810203108.28770-1-pawelwod@gmail.com \
--to=pawelwod@gmail.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).