DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/ixgbe: fix fdir flows with RTE_FLOW_ITEM_TYPE_RAW
@ 2020-08-10 20:31 Pawel Wodkowski
  2020-08-31  3:46 ` Zhang, Qi Z
  0 siblings, 1 reply; 3+ messages in thread
From: Pawel Wodkowski @ 2020-08-10 20:31 UTC (permalink / raw)
  To: dev; +Cc: Pawel Wodkowski, qi.z.zhang, Wei Zhao, Jeff Guo

Flows like IP4 / UDP / RAW are not working because after parsing
RTE_FLOW_ITEM_TYPE_RAW item pointer is not advanced. This make whole
parsing fail.

Fixes: f35fec63dde1 ("net/ixgbe: enable flex bytes for generic flow API")
Cc: qi.z.zhang@intel.com
Signed-off-by: Pawel Wodkowski <pawelwod@gmail.com>
---
 drivers/net/ixgbe/ixgbe_flow.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
index b2a2bfc02..a2cb599b1 100644
--- a/drivers/net/ixgbe/ixgbe_flow.c
+++ b/drivers/net/ixgbe/ixgbe_flow.c
@@ -2251,6 +2251,8 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev,
 			(((uint16_t)raw_spec->pattern[1]) << 8) |
 			raw_spec->pattern[0];
 		rule->flex_bytes_offset = raw_spec->offset;
+
+		item = next_no_fuzzy_pattern(pattern, item);
 	}
 
 	if (item->type != RTE_FLOW_ITEM_TYPE_END) {
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/ixgbe: fix fdir flows with RTE_FLOW_ITEM_TYPE_RAW
  2020-08-10 20:31 [dpdk-dev] [PATCH] net/ixgbe: fix fdir flows with RTE_FLOW_ITEM_TYPE_RAW Pawel Wodkowski
@ 2020-08-31  3:46 ` Zhang, Qi Z
  2020-09-02  8:51   ` Pawel Wodkowski
  0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Qi Z @ 2020-08-31  3:46 UTC (permalink / raw)
  To: Pawel Wodkowski, dev; +Cc: Zhao1, Wei, Guo, Jia



> -----Original Message-----
> From: Pawel Wodkowski <pawelwod@gmail.com>
> Sent: Tuesday, August 11, 2020 4:31 AM
> To: dev@dpdk.org
> Cc: Pawel Wodkowski <pawelwod@gmail.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>; Guo, Jia
> <jia.guo@intel.com>
> Subject: [PATCH] net/ixgbe: fix fdir flows with RTE_FLOW_ITEM_TYPE_RAW
> 
> Flows like IP4 / UDP / RAW are not working because after parsing
> RTE_FLOW_ITEM_TYPE_RAW item pointer is not advanced. This make whole
> parsing fail.
> 
> Fixes: f35fec63dde1 ("net/ixgbe: enable flex bytes for generic flow API")
> Cc: qi.z.zhang@intel.com
> Signed-off-by: Pawel Wodkowski <pawelwod@gmail.com>
> ---
>  drivers/net/ixgbe/ixgbe_flow.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
> index b2a2bfc02..a2cb599b1 100644
> --- a/drivers/net/ixgbe/ixgbe_flow.c
> +++ b/drivers/net/ixgbe/ixgbe_flow.c
> @@ -2251,6 +2251,8 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev
> *dev,
>  			(((uint16_t)raw_spec->pattern[1]) << 8) |
>  			raw_spec->pattern[0];
>  		rule->flex_bytes_offset = raw_spec->offset;
> +
> +		item = next_no_fuzzy_pattern(pattern, item);

why we need to advance item pointer?
The next branch will advance it and compare with RTe_FLOW_ITEM_TYPE_END.
Can you double check if your pattern is IPv4/UDP/RAW/END ?

>  	}
> 
>  	if (item->type != RTE_FLOW_ITEM_TYPE_END) {
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/ixgbe: fix fdir flows with RTE_FLOW_ITEM_TYPE_RAW
  2020-08-31  3:46 ` Zhang, Qi Z
@ 2020-09-02  8:51   ` Pawel Wodkowski
  0 siblings, 0 replies; 3+ messages in thread
From: Pawel Wodkowski @ 2020-09-02  8:51 UTC (permalink / raw)
  To: Zhang, Qi Z, dev; +Cc: Zhao1, Wei, Guo, Jia



On 31.08.2020 05:46, Zhang, Qi Z wrote:
>
>> -----Original Message-----
>> From: Pawel Wodkowski <pawelwod@gmail.com>
>> Sent: Tuesday, August 11, 2020 4:31 AM
>> To: dev@dpdk.org
>> Cc: Pawel Wodkowski <pawelwod@gmail.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>; Guo, Jia
>> <jia.guo@intel.com>
>> Subject: [PATCH] net/ixgbe: fix fdir flows with RTE_FLOW_ITEM_TYPE_RAW
>>
>> Flows like IP4 / UDP / RAW are not working because after parsing
>> RTE_FLOW_ITEM_TYPE_RAW item pointer is not advanced. This make whole
>> parsing fail.
>>
>> Fixes: f35fec63dde1 ("net/ixgbe: enable flex bytes for generic flow API")
>> Cc: qi.z.zhang@intel.com
>> Signed-off-by: Pawel Wodkowski <pawelwod@gmail.com>
>> ---
>>   drivers/net/ixgbe/ixgbe_flow.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
>> index b2a2bfc02..a2cb599b1 100644
>> --- a/drivers/net/ixgbe/ixgbe_flow.c
>> +++ b/drivers/net/ixgbe/ixgbe_flow.c
>> @@ -2251,6 +2251,8 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev
>> *dev,
>>   			(((uint16_t)raw_spec->pattern[1]) << 8) |
>>   			raw_spec->pattern[0];
>>   		rule->flex_bytes_offset = raw_spec->offset;
>> +
>> +		item = next_no_fuzzy_pattern(pattern, item);
> why we need to advance item pointer?
> The next branch will advance it and compare with RTe_FLOW_ITEM_TYPE_END.
> Can you double check if your pattern is IPv4/UDP/RAW/END ?

True, pls ignore this patch.

>
>>   	}
>>
>>   	if (item->type != RTE_FLOW_ITEM_TYPE_END) {
>> --
>> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-09-02  8:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-10 20:31 [dpdk-dev] [PATCH] net/ixgbe: fix fdir flows with RTE_FLOW_ITEM_TYPE_RAW Pawel Wodkowski
2020-08-31  3:46 ` Zhang, Qi Z
2020-09-02  8:51   ` Pawel Wodkowski

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git