From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id BA003A04CC;
Mon, 10 Aug 2020 22:31:36 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id D90F01DBF;
Mon, 10 Aug 2020 22:31:35 +0200 (CEST)
Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com
[209.85.208.193]) by dpdk.org (Postfix) with ESMTP id 93B7AF94
for <dev@dpdk.org>; Mon, 10 Aug 2020 22:31:34 +0200 (CEST)
Received: by mail-lj1-f193.google.com with SMTP id t23so11083310ljc.3
for <dev@dpdk.org>; Mon, 10 Aug 2020 13:31:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:cc:subject:date:message-id;
bh=V4TiSARYEAb4vvigFUH4cMDDEgROiI078T+xU/jfhi4=;
b=WgQKhCjEoZyXp5hzo2qwARVUsJ+1bqLMXMzuBSsyf2eYFaApABIE0QDMCLohNao9Er
UHHpctK9ObOX7gmBspgAfRZHHK8y1vBCttApSj/FkU3+aomXnuOllYYmeuuGsS7EosZs
bGbQ88cs5zLoTw6Q3It49zz42Q+IY3FEadJV1uHmQ5rjoJ7cjPOtoEMsFiI0LTVAxV3C
pa2dxWZVev/CnihyvLvdqyQKMjWtfjFVElbcNi6DVDst4jEPZFitN32P/tX0ivjEzSzU
8vylHH36/YI/BXPItIoEYnSCKBjKOanapF9YfO+K7T1Kgj7Dkh7rNvOl4x48+Y/Twhh4
1Q0A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id;
bh=V4TiSARYEAb4vvigFUH4cMDDEgROiI078T+xU/jfhi4=;
b=DZ+vrvRQ6DCJabhrSIuQ8F1n6+h1PgoHOFQJgglJT8lPqJPQN5rdMJbDxoQaPQuPRM
7uXSSvdKlSgkZJNn203gmjvZWezRP7p2gQnBo23lemCqPI6Z4y4bM8/QStBSM3FIdkcK
ZtD9yioS5ulhymT+8+ytdIIiV2PV7TS8wDfI31j0JLFt6UCu5jGZBiw421365C+ZOo9l
tzB9Igke9uIfqno7cJWJHa5ejBdPltN9DURxahNQi9Gebim7yvoyjeYM/z6cyKwxzNAR
M/GzhppigaSLT/50YbUtybFkHnVLcb2YUy8uIIzq3ifgQK4IEGvqWMycS+MDQeyV7rQi
DcIA==
X-Gm-Message-State: AOAM5313RdojfNHH0eGshZ68tH6V/CNIEfvR6wRRCHs7cvyPnt3qrnQz
dP0jOCnQdmM0LW6ALE3NYaf9/TodcEGbLVnY
X-Google-Smtp-Source: ABdhPJw+5Dp7FUY9mmZDs3iw7/sS5zXg3XtVCAqVi3lMWUwTxYKbCPQWvYNlE0UFCCLnDbgqRMh4/A==
X-Received: by 2002:a2e:b00c:: with SMTP id y12mr1415137ljk.18.1597091493768;
Mon, 10 Aug 2020 13:31:33 -0700 (PDT)
Received: from machina.creanord.lan ([194.100.60.111])
by smtp.gmail.com with ESMTPSA id c5sm11025389lfb.24.2020.08.10.13.31.32
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 10 Aug 2020 13:31:33 -0700 (PDT)
From: Pawel Wodkowski <pawelwod@gmail.com>
To: dev@dpdk.org
Cc: Pawel Wodkowski <pawelwod@gmail.com>, qi.z.zhang@intel.com,
Wei Zhao <wei.zhao1@intel.com>, Jeff Guo <jia.guo@intel.com>
Date: Mon, 10 Aug 2020 22:31:08 +0200
Message-Id: <20200810203108.28770-1-pawelwod@gmail.com>
X-Mailer: git-send-email 2.17.1
Subject: [dpdk-dev] [PATCH] net/ixgbe: fix fdir flows with
RTE_FLOW_ITEM_TYPE_RAW
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Flows like IP4 / UDP / RAW are not working because after parsing
RTE_FLOW_ITEM_TYPE_RAW item pointer is not advanced. This make whole
parsing fail.
Fixes: f35fec63dde1 ("net/ixgbe: enable flex bytes for generic flow API")
Cc: qi.z.zhang@intel.com
Signed-off-by: Pawel Wodkowski <pawelwod@gmail.com>
---
drivers/net/ixgbe/ixgbe_flow.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
index b2a2bfc02..a2cb599b1 100644
--- a/drivers/net/ixgbe/ixgbe_flow.c
+++ b/drivers/net/ixgbe/ixgbe_flow.c
@@ -2251,6 +2251,8 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev,
(((uint16_t)raw_spec->pattern[1]) << 8) |
raw_spec->pattern[0];
rule->flex_bytes_offset = raw_spec->offset;
+
+ item = next_no_fuzzy_pattern(pattern, item);
}
if (item->type != RTE_FLOW_ITEM_TYPE_END) {
--
2.17.1