From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7721A034C; Tue, 18 Aug 2020 15:48:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 749431C119; Tue, 18 Aug 2020 15:47:12 +0200 (CEST) Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by dpdk.org (Postfix) with ESMTP id 421491C0DB for ; Wed, 12 Aug 2020 11:25:52 +0200 (CEST) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07C9GoYj161014; Wed, 12 Aug 2020 09:25:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=corp-2020-01-29; bh=jEyMD4LUw50m2dSTT85pA6Ib+2DmRrnobUIVlsruIM0=; b=gUdF0STXnD+vEzRcl8CGvQ7c8wcQwJ7vROWneNHFlxsJvdTgRNAHv7k4teAH5YXVXc0g reWodKJx5KBRM+9+kzaMMwJOGJD+LxsQ0QVBx1LXqxpkL6Ikoe0Lk4+2V8UY8oMEIgzJ FVSkfyDm3XWcIn4+2JlRCpQ17EO21mSvcWlyAmJvkuiPSZ8GCbeAXYSG4GzmVdUXQJXO 3k+CpAhJnUtPKkvyn8jiXYXmYzP3sUhqVrnV/B5OPFMgHR5VhdmaYykaD/uyV7BLzjBY yBFmdjt53VWTW2vGSPySzriJp0EOPV23zgG1rOSJ5u6qargaBNxgIHPb9B2eKo8rjId/ RA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 32smpnhjef-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 12 Aug 2020 09:25:50 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07C9JLLR195074; Wed, 12 Aug 2020 09:23:50 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 32t5y6djcy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Aug 2020 09:23:50 +0000 Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 07C9NmGe010786; Wed, 12 Aug 2020 09:23:48 GMT Received: from VASHRI-IN.in.oracle.com (/10.76.42.229) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 12 Aug 2020 09:23:42 +0000 From: Vipul Ashri To: dev@dpdk.org Cc: chenbo.xia@intel.com, vipul.ashri@oracle.com, edwin.leung@oracle.com Date: Wed, 12 Aug 2020 14:53:06 +0530 Message-Id: <20200812092306.1345-1-vipul.ashri@oracle.com> X-Mailer: git-send-email 2.28.0.windows.1 In-Reply-To: <20200810195958.1239-1-vipul.ashri@oracle.com> References: <20200810195958.1239-1-vipul.ashri@oracle.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9710 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 suspectscore=1 mlxscore=0 adultscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008120066 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9710 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 impostorscore=0 phishscore=0 clxscore=1015 spamscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 mlxscore=0 suspectscore=1 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008120066 X-Mailman-Approved-At: Tue, 18 Aug 2020 15:47:00 +0200 Subject: [dpdk-dev] [PATCH v2] Fixes: 57f90f894588("net/virtio: reuse packed ring functions") X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Problem - Standard Tx packets are not going out and found broken due to cleanup malfunctioning whereever below mentioned macro is used. RootCause - Here inside Macro 'ASSIGN_UNLESS_EQUAL(var, val)' assignment to 'var' argument passed is always failing as assignment done using 'var_' having local scope only. Signed-off-by: Vipul Ashri --- drivers/net/virtio/virtqueue.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h index 105a9c00c..20c95471e 100644 --- a/drivers/net/virtio/virtqueue.h +++ b/drivers/net/virtio/virtqueue.h @@ -607,10 +607,8 @@ virtqueue_notify(struct virtqueue *vq) /* avoid write operation when necessary, to lessen cache issues */ #define ASSIGN_UNLESS_EQUAL(var, val) do { \ - typeof(var) var_ = (var); \ - typeof(val) val_ = (val); \ - if ((var_) != (val_)) \ - (var_) = (val_); \ + if ((var) != (val)) \ + (var) = (val); \ } while (0) #define virtqueue_clear_net_hdr(hdr) do { \ -- 2.28.0.windows.1