From: <skori@marvell.com>
To: Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>
Cc: <dev@dpdk.org>, Pawel Wodkowski <pawelwod@gmail.com>
Subject: [dpdk-dev] [PATCH v3] trace: fix compilation with C++
Date: Wed, 12 Aug 2020 15:21:50 +0530 [thread overview]
Message-ID: <20200812095150.1486443-1-skori@marvell.com> (raw)
In-Reply-To: <20200810203610.29470-1-pawelwod@gmail.com>
From: Pawel Wodkowski <pawelwod@gmail.com>
trace_mem is declared as 'void *' which triggers following error:
'...invalid conversion from ‘void*’ to ‘__rte_trace_header*’
[-fpermissive]...'
Fix this by adding proper typecast to 'struct __rte_trace_header *'.
Fixes: ebaee6409702 ("trace: simplify trace point headers")
Signed-off-by: Pawel Wodkowski <pawelwod@gmail.com>
---
v3:
- fix subject.
v2:
- Update proper typecasting.
lib/librte_eal/include/rte_trace_point.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/include/rte_trace_point.h b/lib/librte_eal/include/rte_trace_point.h
index b03960277..6446f2f0f 100644
--- a/lib/librte_eal/include/rte_trace_point.h
+++ b/lib/librte_eal/include/rte_trace_point.h
@@ -298,13 +298,14 @@ RTE_DECLARE_PER_LCORE(void *, trace_mem);
static __rte_always_inline void *
__rte_trace_mem_get(uint64_t in)
{
- struct __rte_trace_header *trace = RTE_PER_LCORE(trace_mem);
+ struct __rte_trace_header *trace =
+ (struct __rte_trace_header *)(RTE_PER_LCORE(trace_mem));
const uint16_t sz = in & __RTE_TRACE_FIELD_SIZE_MASK;
/* Trace memory is not initialized for this thread */
if (unlikely(trace == NULL)) {
__rte_trace_mem_per_thread_alloc();
- trace = RTE_PER_LCORE(trace_mem);
+ trace = (struct __rte_trace_header *)(RTE_PER_LCORE(trace_mem));
if (unlikely(trace == NULL))
return NULL;
}
--
2.25.1
next prev parent reply other threads:[~2020-08-12 9:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 17:51 [dpdk-dev] [PATCH] tracepoint: " Pawel Wodkowski
2020-08-05 8:00 ` David Marchand
2020-08-05 9:26 ` Pawel Wodkowski
2020-08-06 6:44 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-08-06 18:44 ` Pawel Wodkowski
2020-08-07 5:54 ` Sunil Kumar Kori
2020-08-10 20:36 ` [dpdk-dev] [PATCH v2] " Pawel Wodkowski
2020-08-11 9:29 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-08-11 13:34 ` Pawel Wodkowski
2020-08-12 6:51 ` Sunil Kumar Kori
2020-08-12 9:51 ` skori [this message]
2020-09-11 20:33 ` [dpdk-dev] [PATCH v3] trace: " Chautru, Nicolas
2020-09-17 8:16 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200812095150.1486443-1-skori@marvell.com \
--to=skori@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pawelwod@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).