From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2398A04DB; Wed, 12 Aug 2020 21:21:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 387941C0D5; Wed, 12 Aug 2020 21:21:02 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id 607F71C0D4 for ; Wed, 12 Aug 2020 21:21:01 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E04C8D6E; Wed, 12 Aug 2020 12:21:00 -0700 (PDT) Received: from localhost.localdomain (unknown [10.57.38.163]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9A0E33F22E; Wed, 12 Aug 2020 12:20:59 -0700 (PDT) From: Steven Lariau To: Gage Eads , Olivier Matz Cc: dev@dpdk.org, nd@arm.com, Steven Lariau Date: Wed, 12 Aug 2020 20:18:47 +0100 Message-Id: <20200812191847.16529-5-steven.lariau@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200812191847.16529-1-steven.lariau@arm.com> References: <20200805155721.19808-1-steven.lariau@arm.com> <20200812191847.16529-1-steven.lariau@arm.com> Subject: [dpdk-dev] [PATCH v2 4/4] test/stack: remove atomics operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Remove the part that checks if there is enough room in the stack, it's always true as long as size of stack >= MAX_BULK*rte_lcore_count(). This check used an atomic cmpset, and read / write to a shared size variable. These operations result in some form of synchronization that might get in the way of the actual stack testing. Signed-off-by: Steven Lariau Reviewed-by: Dharmik Thakkar Reviewed-by: Phil Yang Reviewed-by: Ruifeng Wang Acked-by: Gage Eads --- app/test/test_stack.c | 24 +++--------------------- 1 file changed, 3 insertions(+), 21 deletions(-) diff --git a/app/test/test_stack.c b/app/test/test_stack.c index d959b566a..463460ccc 100644 --- a/app/test/test_stack.c +++ b/app/test/test_stack.c @@ -273,7 +273,6 @@ test_free_null(void) struct test_args { struct rte_stack *s; - rte_atomic64_t *sz; }; static struct test_args thread_test_args; @@ -285,21 +284,9 @@ stack_thread_push_pop(__rte_unused void *args) int i; for (i = 0; i < NUM_ITERS_PER_THREAD; i++) { - unsigned int success, num; + unsigned int num; - /* Reserve up to min(MAX_BULK, available slots) stack entries, - * then push and pop those stack entries. - */ - do { - uint64_t sz = rte_atomic64_read(thread_test_args.sz); - volatile uint64_t *sz_addr; - - sz_addr = (volatile uint64_t *)thread_test_args.sz; - - num = RTE_MIN(rte_rand() % MAX_BULK, STACK_SIZE - sz); - - success = rte_atomic64_cmpset(sz_addr, sz, sz + num); - } while (success == 0); + num = rte_rand() % MAX_BULK; if (rte_stack_push(thread_test_args.s, obj_table, num) != num) { printf("[%s():%u] Failed to push %u pointers\n", @@ -312,8 +299,6 @@ stack_thread_push_pop(__rte_unused void *args) __func__, __LINE__, num); return -1; } - - rte_atomic64_sub(thread_test_args.sz, num); } return 0; @@ -324,7 +309,6 @@ test_stack_multithreaded(uint32_t flags) { unsigned int lcore_id; struct rte_stack *s; - rte_atomic64_t size; int result = 0; if (rte_lcore_count() < 2) { @@ -335,16 +319,14 @@ test_stack_multithreaded(uint32_t flags) printf("[%s():%u] Running with %u lcores\n", __func__, __LINE__, rte_lcore_count()); - s = rte_stack_create("test", STACK_SIZE, rte_socket_id(), flags); + s = rte_stack_create("test", MAX_BULK * rte_lcore_count(), rte_socket_id(), flags); if (s == NULL) { printf("[%s():%u] Failed to create a stack\n", __func__, __LINE__); return -1; } - rte_atomic64_init(&size); thread_test_args.s = s; - thread_test_args.sz = &size; if (rte_eal_mp_remote_launch(stack_thread_push_pop, NULL, CALL_MASTER)) rte_panic("Failed to launch tests\n"); -- 2.17.1