From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3302BA04B1; Fri, 14 Aug 2020 05:18:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 40BE01C0C3; Fri, 14 Aug 2020 05:18:45 +0200 (CEST) Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by dpdk.org (Postfix) with ESMTP id BC2711C0C0 for ; Fri, 14 Aug 2020 05:18:43 +0200 (CEST) Received: by mail-pj1-f68.google.com with SMTP id t6so3739891pjr.0 for ; Thu, 13 Aug 2020 20:18:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gdAFEUSM2gBINRz9524xsBdP71UplhqhH7Azs/+EWj8=; b=Jzh5BauOuvc2AgkOlp4++SALK7LgcHwP36omZbLhGQCfvvAFdLq/e1blw/SmjTnA6g UFisnIe5nD3GYl3mjiVpM/h+L5pzF8tH58N0nfiJxIHLm95QVgY201cp62VxmA0oiAeq QxNcdZAk43a7OYLohU3Ij0RaljXuQB3iKBfLeXMaAjZl3i4/y1x4gwCabYTkYhqoDN4G m1XWPsmAemB8XQoRkD7mH1z+HMVHPR10Q8nvf9Z9M9w+wlserzdqOWGwVkWSbj2+ilUH 9YPVEvLT8yXjChtyS4n4JNvo8Q60r9s7XbeqCxrl7SxJfcOwuqwz2gRHaVp2t+3lKcl9 N07w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gdAFEUSM2gBINRz9524xsBdP71UplhqhH7Azs/+EWj8=; b=DXCXKHnAbN+Fue+DkkQISTXH1xBY8hEHN6sSe7I7Eh7WWvs589jRn0117hOXWPZpav 9pqWf7poCux4svV5txmw6oChqxmNAWjPYe/yuIam8kJwdokf8uaiUFC7c7/U52ueXdhE qwEkhlr7VJK9Q+zXloblmBBklnjlUhEcnTK8lsCXWdxriDDr1yhYxJCsTWiWk6qE4rfp gxcoaLvaAUep4nr6BFDtanQUoE9hbIs2FbReDG02WcjtgmKl/kVC+2GlKky6q9V+612a vt6+5Z4swu/y7htQyuXjIhzpV0ssfJAPRMktFVKDxa70zOZNBXEz3ZySeTRGoGwdywYK 6GBw== X-Gm-Message-State: AOAM533N47E8Gok/gbyIH1RXKc0Cj0OoievoKkzO0fQ6juRjKB7wezhp fHIv+rcDs4eUw87vDqyNod+JWg== X-Google-Smtp-Source: ABdhPJx+NZdobVRys8ySTpaLctzKo5Bls9TdS5hPLDwfBtZ89dISFqzYUvRurX+iD5yGK2YvCtPdUg== X-Received: by 2002:a17:90b:1b45:: with SMTP id nv5mr639247pjb.35.1597375122599; Thu, 13 Aug 2020 20:18:42 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 3sm6622305pjo.40.2020.08.13.20.18.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2020 20:18:42 -0700 (PDT) Date: Thu, 13 Aug 2020 20:18:33 -0700 From: Stephen Hemminger To: "Varghese, Vipin" Cc: Thomas Monjalon , "Tahhan, Maryam" , "Pattan, Reshma" , "hemant.agrawal@nxp.com" , "dev@dpdk.org" Message-ID: <20200813201833.09b95d69@hermes.lan> In-Reply-To: References: <20200506193741.24117-1-stephen@networkplumber.org> <20200715212228.28010-1-stephen@networkplumber.org> <20200715212228.28010-3-stephen@networkplumber.org> <1686569.X5dskYFTH4@thomas> <20200813091121.3b3f9e9d@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 2/7] app/proc-info: eliminate useless borders X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 14 Aug 2020 01:14:40 +0000 "Varghese, Vipin" wrote: > snipped > > > > snipped > > > > > > > > snipped > > > > > > > > > > 15/07/2020 23:22, Stephen Hemminger: > > > > > > Printing extra borders does not improve readability, and is just > > > > > > unnecessary. Putting TSC hz in header also makes no sense here. > > > > > > > > > > The CPU frequency on headers! > > > > > OK to remove :) > > > > > > > > > > > > > The rational of having Time Stamp Counter as the header for port > > > > info and > > > stats, is to account for each iteration for an average `packets per > > > second`. That is using `watch -d -n 1 ./dpdk-procinfo -- --xstats | grep -v ": 0"`. > > > > > > > > But if there better way to do this or add as new feature, +1 to remove. > > > > > > Proc info should just use standard clock for its updates, not TSC? > > > > Can you please explain the rationale behind the (syscall for time) and not TSC? > > Looking forward for the patch with clock change too. There is no part of what proc-info is show with xstats that displays or uses tsc directly. Do you have a driver that is putting TSC information in xstats?