From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CDE3A04AF; Fri, 14 Aug 2020 16:57:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7B0401C0D2; Fri, 14 Aug 2020 16:57:31 +0200 (CEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 3A8AC1C0BD for ; Fri, 14 Aug 2020 16:57:30 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id u20so4691277pfn.0 for ; Fri, 14 Aug 2020 07:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s7ytiwiXI6VZUrT+6oqdb/zTllQBlh+it1RalbC5/Xs=; b=lcP28+rX1jMIZEQskb9OhcceCOI0AIHjQS3SRvKDEZIu3utv76ynNPKicXhsEiiLec Uvkt4tajfkhdO9KOX+kdsZ20Pd2mZJwqQUAtiXZVNNeiBPjjKYq0/KMhk0Uz8O/Mltia DjzjYeyvsRsEloAbSr7i4ZKB7yFZ9QXccSpnrRsU9q0twQGbcoNkqJxXItIvBia3qie+ De+ZtEz+fygEUkdD0zaQ+fpGFujxdpX6UzNsksfaKgOoSf+RYP8NzZHYvfuPPK+aPtKr 3BL0TImXj6D6D2V3Dy4ijhKLqNBshcaSYYfEFgS0ZANqvOfSfPcYhukSO1CooNoReIaA dAbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s7ytiwiXI6VZUrT+6oqdb/zTllQBlh+it1RalbC5/Xs=; b=OG9kmD30ZAWxaXWo6rgWm5yqF4rWW2v3N+rM1lSX4RnRBT1FuFsklK5vcsc7pF6odq S6sdg/dBF4MnLotV4AMx2VWV6ZYIM0zWTBp/yJCXocu4/mcPwQHtfPfVVj115+gGC3XJ qd+g5K1GhhhLrZ8NESK6HoamnvpFyXb94ZDn5iugFWGh68+RqJayQPx/F6m5dXf2W7aL l9Tj+57S5yqjPhU7E1intVdEblKfHvqsGjb/6UztLDz4UPg0HHMAnr8nL3p06o5KE4TG A1vjS/ZkndSW5h9ehe6uIVPV2NzAahyX3sGvmcy2Tyy2qlPg7meRj0YTrXeWEMpbpgSC 5mNg== X-Gm-Message-State: AOAM530YOvB05fgJ1Dn8TXWGUE1gYAKj5UNTJudWvHcbVPBBGmb/Xr9z 4riU90hKC88iwxvWswv6m6vO9g== X-Google-Smtp-Source: ABdhPJyef5fuRnHF5nmfdbRphHoBDtSnO9cv5FmvzmDN64/wK98UDq3qrVdrrgdd+mEnvhy19f5ecA== X-Received: by 2002:a63:cd54:: with SMTP id a20mr1984404pgj.228.1597417049170; Fri, 14 Aug 2020 07:57:29 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id t63sm8570375pgt.50.2020.08.14.07.57.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2020 07:57:28 -0700 (PDT) Date: Fri, 14 Aug 2020 07:56:58 -0700 From: Stephen Hemminger To: "Varghese, Vipin" Cc: Thomas Monjalon , "Tahhan, Maryam" , "Pattan, Reshma" , "hemant.agrawal@nxp.com" , "dev@dpdk.org" Message-ID: <20200814075658.2b8544b1@hermes.lan> In-Reply-To: References: <20200506193741.24117-1-stephen@networkplumber.org> <20200715212228.28010-1-stephen@networkplumber.org> <20200715212228.28010-3-stephen@networkplumber.org> <1686569.X5dskYFTH4@thomas> <20200813091121.3b3f9e9d@hermes.lan> <20200813201833.09b95d69@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 2/7] app/proc-info: eliminate useless borders X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 14 Aug 2020 11:08:31 +0000 "Varghese, Vipin" wrote: > Hi Stephen, > > > > > > snipped > > > > > > > > snipped > > > > > > > > > > > > snipped > > > > > > > > > > > > > > 15/07/2020 23:22, Stephen Hemminger: > > > > > > > > Printing extra borders does not improve readability, and is > > > > > > > > just unnecessary. Putting TSC hz in header also makes no sense > > here. > > > > > > > > > > > > > > The CPU frequency on headers! > > > > > > > OK to remove :) > > > > > > > > > > > > > > > > > > > The rational of having Time Stamp Counter as the header for port > > > > > > info and > > > > > stats, is to account for each iteration for an average `packets > > > > > per second`. That is using `watch -d -n 1 ./dpdk-procinfo -- --xstats | grep - > > v ": 0"`. > > > > > > > > > > > > But if there better way to do this or add as new feature, +1 to remove. > > > > > > > > > > Proc info should just use standard clock for its updates, not TSC? > > > > > > > > Can you please explain the rationale behind the (syscall for time) and not > > TSC? > > > > > > Looking forward for the patch with clock change too. > > > > There is no part of what proc-info is show with xstats that displays or uses tsc > > directly. > > Do you have a driver that is putting TSC information in xstats? > > I am sorry I did not follow you on this, In the earlier implementation with `proc-info` header we had TSC so coupling `--show --xstats`. But with the header removed out with TSC, how can we get this? I am asking why is the TSC hz a useful piece of information here? Sure, proc-info could print lots of things but unless it serves a useful purpose for examining the interfaces, it is just noise. Developers love to clutter output, but it just raises the signal to noise ratio.