From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CAD4A04B0; Fri, 14 Aug 2020 12:29:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DA6AC1C0C3; Fri, 14 Aug 2020 12:29:36 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id BB3B51BFF3 for ; Fri, 14 Aug 2020 12:29:34 +0200 (CEST) IronPort-SDR: Semk3++6bLsbzKlLBfNjqp0ZASyVnmmIaH7gG18tFi2wSvheJl73InnPzK/j+TWkXxDQokdY/i 8Np1MvSe4b9g== X-IronPort-AV: E=McAfee;i="6000,8403,9712"; a="154347416" X-IronPort-AV: E=Sophos;i="5.76,312,1592895600"; d="scan'208";a="154347416" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2020 03:29:33 -0700 IronPort-SDR: GLDulQWuYRDp5ILS+pRzfiyZPuaXPiblPlzDgmGU89FOt94qfflngEL8UzYa1sG4o73m0BzBac RML9sHddjHGw== X-IronPort-AV: E=Sophos;i="5.76,312,1592895600"; d="scan'208";a="470547785" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.45.63]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 14 Aug 2020 03:29:32 -0700 Date: Fri, 14 Aug 2020 11:29:28 +0100 From: Bruce Richardson To: Ciara Power Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20200814102928.GC1970@bricha3-MOBL.ger.corp.intel.com> References: <20200807123009.21266-1-ciara.power@intel.com> <20200807123009.21266-2-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200807123009.21266-2-ciara.power@intel.com> Subject: Re: [dpdk-dev] [PATCH 20.11 01/19] examples: remove legacy sections of makefiles X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Aug 07, 2020 at 01:29:51PM +0100, Ciara Power wrote: > The example app makefiles contained sections using the legacy method of > compiling with make. These are no longer needed, and are removed, > leaving only the section that uses pkg-config for the make build. > > Signed-off-by: Ciara Power > --- > examples/bbdev_app/Makefile | 23 ++------------- > examples/vmdq/Makefile | 23 ++------------- > examples/vmdq_dcb/Makefile | 31 ++------------------ > 43 files changed, 129 insertions(+), 1078 deletions(-) > > diff --git a/examples/bbdev_app/Makefile b/examples/bbdev_app/Makefile > index 3c8eb75a4e..9675c6d096 100644 > --- a/examples/bbdev_app/Makefile > +++ b/examples/bbdev_app/Makefile > @@ -8,7 +8,9 @@ APP = bbdev > SRCS-y := main.c > > # Build using pkg-config variables if possible > -ifeq ($(shell pkg-config --exists libdpdk && echo 0),0) > +ifneq ($(shell pkg-config --exists libdpdk && echo 0),0) > + $(error "no installation of DPDK found") > +endif > Unfortunately make is whitespace sensitive, so you can't indent here without getting a syntax error in the case that dpdk is not installed. Instead of the error message you get e.g.: Makefile:12: *** recipe commences before first target. Stop. This applies to all makefiles in this patch, I think. /Bruce