From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8AF3A04B0; Fri, 14 Aug 2020 21:20:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D1A681C0CF; Fri, 14 Aug 2020 21:20:38 +0200 (CEST) Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by dpdk.org (Postfix) with ESMTP id DC7D51C0C5 for ; Fri, 14 Aug 2020 21:20:37 +0200 (CEST) Received: by mail-pj1-f65.google.com with SMTP id ha11so4838531pjb.1 for ; Fri, 14 Aug 2020 12:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=n37KuZkK6y3KgSxJFAOjQvCBFUMDeyKxsR+HC0qgD8k=; b=OwlShL9kUE7aB4hCC8anQVSo3Q7ww3zEMKrW+qoa40Uuf1p380F9TKlz37RlkkirAY o3pr7ybUf6BCWy8/7E2epL2R1AkwosruotobyT5dZ/PsHsnWlOnnVkHoyYAUDMRAzdCK AEncMoqKcQGSzNbq799tEK0glH3s21F9MYSVdu/Wj4fU+hI+abPKV1pnci9xvR0YlJyY Gib4hH2FCU/yhUMFB4Hf9aHjRMzVK4B2LlC2tDhWGCrE7vJVIikEeOX4J4Hrc9zAyFLm EPufa0j13C0xNVau/McGRWWPDDYBS+otFUqLdDvnnihS5fGDDeT97D3hkEnGuGAP3mMz fVtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=n37KuZkK6y3KgSxJFAOjQvCBFUMDeyKxsR+HC0qgD8k=; b=i4SMkXfFHJmxIJcInMITPbWD4xz/pK+DhKu39Jpr339VRCLQZO+1D1tl39dWWZLxKN eDTHgJW0VaJwbjzU94OGveZjdaarmqQ21D1O870zwPxtqT3ItcKYsAv48a+6qX75Rg/O 79qv2GT+ZimqUPBZifEWAaj9uaVwRKXh9I/QTgS9nexY0nqEGjJqwxS6+CanB6+itQ0I I5088+XFoOj1SApD/fGFnZSZITvKMW07dU8IT0LwSpjVyEch0AHnoP5HaxDx3swN1lD5 rVFNzRPTxXCZGPPEkidMO5eIt0+wE3g75h46QL1Lvss3ErI1fjDW3+BjCPK1x0UrBedp GBNg== X-Gm-Message-State: AOAM532gO7mP0DXhwefRvMJE7W1oHmeow5auqBorco+ndOaZyp54w3nd wO6mNbjGnY5adHu7IYO0lWg16w== X-Google-Smtp-Source: ABdhPJywK6eJxY9tDVHHjM4XRH58a2oBr46gktDptGZeFXHsE9UDMFFKf7dDqPXtMoxGDjDiRdfAgw== X-Received: by 2002:a17:90a:94c4:: with SMTP id j4mr3350994pjw.155.1597432836929; Fri, 14 Aug 2020 12:20:36 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id g1sm10056681pfr.97.2020.08.14.12.20.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2020 12:20:36 -0700 (PDT) Date: Fri, 14 Aug 2020 12:20:28 -0700 From: Stephen Hemminger To: Dmitry Kozlyuk Cc: dev@dpdk.org Message-ID: <20200814122028.312c7c8b@hermes.lan> In-Reply-To: <20200814220911.39097cfa@sovereign> References: <20200814173441.23086-1-stephen@networkplumber.org> <20200814213929.1d7ca040@sovereign> <20200814114549.528d144f@hermes.lan> <20200814220911.39097cfa@sovereign> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: add option to put timestamp on console output X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 14 Aug 2020 22:09:11 +0300 Dmitry Kozlyuk wrote: > On Fri, 14 Aug 2020 11:45:49 -0700, Stephen Hemminger wrote: > > On Fri, 14 Aug 2020 21:39:29 +0300 > > Dmitry Kozlyuk wrote: > [...] > > FreeBsd doesn't go through the same log code. > > Then --log-timestamp shouldn't appear on FreeBSD if it's unsupported. Was using same ifdef that is already there. There are several options already (like syslog facility) which do nothing on FreeBSD anyway. > > > Iovec is to keep timestamp and message as an atomic message. > > There is no good way to use fwrite to get anything atomic. > > Fwrite is unnecessary here anyway saving a copy and avoid issues with library > > getting corrupted is good. > > Got it, thanks.