From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61F3AA04B0; Fri, 14 Aug 2020 19:45:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C97BC1C0CE; Fri, 14 Aug 2020 19:45:25 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 4073A1C0C5 for ; Fri, 14 Aug 2020 19:45:24 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id p37so4873578pgl.3 for ; Fri, 14 Aug 2020 10:45:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BUezVfjxuXFPhDhmkzAReYfjTKtuIVdwk1TCJ+K1x3M=; b=W5oCJjMi4CWoN4wxo7QUwERzp/Og0rQpVJSfqbfN6g7Q5oFn+efxvA5fpehcKgIpse 6TsqXmJjPx/ZAi+e6QKG55gXkBIrS6/j3YtRoxXI7IbUcu2uPY9UfsYwyjKWXWnnBHeK 9x+agdEbSgsl0Hq3tCTXBkOmetT1VLZ3oUyZYwl/jTkKfs4B8RNlP5kzLI5EA8/j1PQT ah6u+Aj7EdM2Hc2Di7IrXNBJv60LTHhJBiSXkoQZgpsDboyBkM+ddPT1u648nhxl+v0i BYhve+wdm69w2wSQFlSzE2LfsUPxG7uH1tIJv6H6tyISjCnKQIdi1TYjEFBkO0fuRxHD lp3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BUezVfjxuXFPhDhmkzAReYfjTKtuIVdwk1TCJ+K1x3M=; b=H/TByX2n90mj/CsiBxPeE1Ey1CfMqe3VFUDcRkQOFdG4eX2oTXq2R7ZHh6q8iJhZPN d4ztTK1R/m99mRPLEidDejVNoGUkk1q5ElLdfb+Il5JQuulxY+zsnWdrteAJBSNeEvd6 EPko0MyrdDjU2dOotlWUC07YJNXabk8Aoi+FXNb9mhfquABByPf/fWW2+8jr7kmqbgr4 9ZP4ml8FpBVBlunLVmdAubKeLW4AbiYoeTFae99405Q3/7MYhOJjSCuehpZe3I/Ih2hd vaoli3kTAUZomlQxlyS1CrWjwdZTWOvjvFl/YaG00KlphQ3iJHyd68tgvcKx0JRi7zVN yfZg== X-Gm-Message-State: AOAM532VUrYx9By1gkoe6EzeOzOAu2zM0BMBZk+qMn4rtczpmiOPcfzD /OeHfVLzZUa088v81enUSK85k3zkGyMURw== X-Google-Smtp-Source: ABdhPJztNOlyuqpmQyByZS3yh+GDJgbr8FT3rPsTU2cRfGnFkXwyEcYGQ3bR7Y6E89DW4jJR07sERA== X-Received: by 2002:a63:2584:: with SMTP id l126mr2426970pgl.126.1597427122923; Fri, 14 Aug 2020 10:45:22 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id m29sm8985468pgc.55.2020.08.14.10.45.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2020 10:45:22 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , jia.guo@intel.com Date: Fri, 14 Aug 2020 10:45:14 -0700 Message-Id: <20200814174514.25100-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] eal: change debug diagnostic message from udev handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The debug message was poorly worded and did not include the part that would be useful. I.e it never said what was being ignored. Change it to print the message so that if udev changes format or other subsystems need to be added then the necessary information will be in the debug log. Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process") Cc: jia.guo@intel.com Signed-off-by: Stephen Hemminger --- lib/librte_eal/linux/eal_dev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/librte_eal/linux/eal_dev.c b/lib/librte_eal/linux/eal_dev.c index 83c9cd660754..83b6068264cb 100644 --- a/lib/librte_eal/linux/eal_dev.c +++ b/lib/librte_eal/linux/eal_dev.c @@ -234,8 +234,7 @@ dev_uev_handler(__rte_unused void *param) ret = dev_uev_parse(buf, &uevent, EAL_UEV_MSG_LEN); if (ret < 0) { - RTE_LOG(DEBUG, EAL, "It is not an valid event " - "that need to be handle.\n"); + RTE_LOG(DEBUG, EAL, "Ignoring uevent '%s'\n", buf); return; } -- 2.27.0