From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 14C2AA04B0;
Fri, 14 Aug 2020 22:26:14 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 63CA01C0C5;
Fri, 14 Aug 2020 22:26:13 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
by dpdk.org (Postfix) with ESMTP id 300581C0C3
for <dev@dpdk.org>; Fri, 14 Aug 2020 22:26:12 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1059)
id 6606820B4908; Fri, 14 Aug 2020 13:26:11 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6606820B4908
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
s=default; t=1597436771;
bh=YBUlXCjnlC+qIbia4ct96A/kUKtha+Ue61Z6szqFjRU=;
h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
b=X3mglsln+qBZdi05mPClMz1SxriH9HM8Cg0ZrTqJ0UwuOz9muT54x6HpYN6jcd1uu
fOF1VPp8MGREdGJSh+FcqCSTjeGbjInXU0uOmnm2DiDt1l4J3JptYrcgokwrXQB0KR
8giHy1KydnuvBG0xmD83z2OhVOstP/oHGfdkOleY=
Date: Fri, 14 Aug 2020 13:26:11 -0700
From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, thomas@monjalon.net, haramakr@linux.microsoft.com,
ocardona@microsoft.com, pallavi.kadam@intel.com,
ranjit.menon@intel.com, dmitrym@microsoft.com,
Narcisa Vasile <navasile@microsoft.com>
Message-ID: <20200814202611.GA96413@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1597360905-74106-1-git-send-email-navasile@linux.microsoft.com>
<20200814230139.62881018@sovereign>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200814230139.62881018@sovereign>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH 00/22] windows/netuio: add netuio driver for
Windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Fri, Aug 14, 2020 at 11:01:39PM +0300, Dmitry Kozlyuk wrote:
> On Thu, 13 Aug 2020 16:21:23 -0700, Narcisa Ana Maria Vasile wrote:
> > From: Narcisa Vasile <navasile@microsoft.com>
> >
> > The NetUIO driver for Windows allows the usermode application
> > to directly access the hardware
>
> > and allocates the memory that gets mapped in usermode.
>
> It doesn't allocate the buffer anymore, does it?
>
> As far as I understand, you're importing history from dpdk-draft-repo and
> then changing file layout. Not sure how this is beneficial, especially
> since there are bugfixes along the way. Or are there legal reasons?
>
Harini, Omar, please advise if we need to preserve history. If not,
I think it's better to just squash all commits and send the netuio code
as one patch. In this way, I can easily make sure that this one patch
has the right signoff, description, subject formatting etc.
Dmitry, would pushing the netuio code as one patch be ok?
> Please follow the guidelines on commit formatting, in particular:
>
> * Subject must have a topic ("windows/netuio"?), its length is limited.
> * Description is mandatory and should explain the changes.