From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 613B9A04B0; Fri, 14 Aug 2020 22:28:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B9ED41C0C5; Fri, 14 Aug 2020 22:28:24 +0200 (CEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by dpdk.org (Postfix) with ESMTP id E20171C0C3 for ; Fri, 14 Aug 2020 22:28:22 +0200 (CEST) X-Originating-IP: 90.92.205.40 Received: from u256.net (lfbn-idf2-1-1144-40.w90-92.abo.wanadoo.fr [90.92.205.40]) (Authenticated sender: grive@u256.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 1846F60004; Fri, 14 Aug 2020 20:28:21 +0000 (UTC) Date: Fri, 14 Aug 2020 22:28:16 +0200 From: =?utf-8?Q?Ga=C3=ABtan?= Rivet To: Stephen Hemminger Cc: dev@dpdk.org, matan@mellanox.com Message-ID: <20200814202816.tzmkk6mwumu753cy@u256.net> References: <20200814173933.23981-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200814173933.23981-1-stephen@networkplumber.org> Subject: Re: [dpdk-dev] [PATCH] net/failsafe: don't double space warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 14/08/20 10:39 -0700, Stephen Hemminger wrote: > Already get a newline from WARN() macro call. > > Fixes: 9dda3e3393c2 ("net/failsafe: add timestamp to stats snapshot") > Cc: matan@mellanox.com > Signed-off-by: Stephen Hemminger Acked-by: Gaetan Rivet > > --- > drivers/net/failsafe/failsafe_ether.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/failsafe/failsafe_ether.c b/drivers/net/failsafe/failsafe_ether.c > index 2b748bd8b426..70972d67174f 100644 > --- a/drivers/net/failsafe/failsafe_ether.c > +++ b/drivers/net/failsafe/failsafe_ether.c > @@ -322,10 +322,10 @@ fs_dev_stats_save(struct sub_device *sdev) > if (err) { > uint64_t timestamp = sdev->stats_snapshot.timestamp; > > - WARN("Could not access latest statistics from sub-device %d.\n", > + WARN("Could not access latest statistics from sub-device %d.", > SUB_ID(sdev)); > if (timestamp != 0) > - WARN("Using latest snapshot taken before %"PRIu64" seconds.\n", > + WARN("Using latest snapshot taken before %"PRIu64" seconds.", > (rte_rdtsc() - timestamp) / rte_get_tsc_hz()); > } > failsafe_stats_increment > -- > 2.27.0 > -- Gaëtan