From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9EF7FA04B0; Fri, 14 Aug 2020 21:09:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 92CB91C0CF; Fri, 14 Aug 2020 21:09:16 +0200 (CEST) Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id 771881C0CE for ; Fri, 14 Aug 2020 21:09:14 +0200 (CEST) Received: by mail-lj1-f196.google.com with SMTP id g6so10982514ljn.11 for ; Fri, 14 Aug 2020 12:09:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CxLsPLd99ao98iuB/8kIWAYbr4tzVc+Vc3PZxJogcgM=; b=e4R20IW3fdwPXfN+NVeT9phd22GA7oIJBzaNV7sedu/o4iuyUblesOukRoNbhe3+ik 3ZE4xy7enfDV9820RxTBV4glAZxOJ1l16hj9QVwqQOukQFLQg97GesqYCw+hf8/QZezk 2jDwPO8YxQW+BgfBziRBesgUBivKIOEZTAQa0hhNVlw/xvIUgANfqDMzBJTyb1pX7+1k uZXRCeg6ellQaq2NFk21Aqo+7n8DDHogqqXm8Fh7Gs02JSgwOcDnfXVT8cHmk7FOHY2h eH9MJMzo8JOADBBeShuf0/Uowp3w2hLJWYxfasYUJ3d0icVifC9cKhxQwrD8b/2FwEgR 4O2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CxLsPLd99ao98iuB/8kIWAYbr4tzVc+Vc3PZxJogcgM=; b=rCjhXXLe2U+akBfYj3vjc4JhqopIUx5kx62VNjR9VJ2VLX4XZ+PnsRe2e2UeouYEQc in+X+sKpN54lu30WJ6P85kuzUDTOpPGm5ma3gxfYTNdlK3xZSK6gUviFeLuyTw3Ibixq rXfc5ibkbJVW62ay0Yaqosic8kg+f5QcYVGOtSdt0mQZClkUgHy+cz2ohNlvNwenrnyN JkSNxpGhef1bZOG3bQ3Pv6xPv79mh5morJ89IU4SbsT2jEX3O37bUq08iniX30UCzxHV /V5UE0ReFJZ4H36D2V5LR5R9/TVyecKcqCKtg+kulLacOGet/5OMWN5XxsALTrQ/JIUF s/rQ== X-Gm-Message-State: AOAM533hebTsjukxhkv/4ojO8rvONH0ChtFKhmEIr4wp84LhP2Pkc9Rg E2D4qNKx2frQKD9GyJwOn9k= X-Google-Smtp-Source: ABdhPJy9m8caScZSn66QvKoUYBGkfhxKmYjSJjpdxTu3bux0KSjNa838ILmyotk3Y4zDIxynnAUWew== X-Received: by 2002:a05:651c:1349:: with SMTP id j9mr1831173ljb.392.1597432153931; Fri, 14 Aug 2020 12:09:13 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id h7sm1920707ljc.75.2020.08.14.12.09.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2020 12:09:12 -0700 (PDT) Date: Fri, 14 Aug 2020 22:09:11 +0300 From: Dmitry Kozlyuk To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20200814220911.39097cfa@sovereign> In-Reply-To: <20200814114549.528d144f@hermes.lan> References: <20200814173441.23086-1-stephen@networkplumber.org> <20200814213929.1d7ca040@sovereign> <20200814114549.528d144f@hermes.lan> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: add option to put timestamp on console output X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 14 Aug 2020 11:45:49 -0700, Stephen Hemminger wrote: > On Fri, 14 Aug 2020 21:39:29 +0300 > Dmitry Kozlyuk wrote: [...] > FreeBsd doesn't go through the same log code. Then --log-timestamp shouldn't appear on FreeBSD if it's unsupported. > Iovec is to keep timestamp and message as an atomic message. > There is no good way to use fwrite to get anything atomic. > Fwrite is unnecessary here anyway saving a copy and avoid issues with library > getting corrupted is good. Got it, thanks.