From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C446A034D; Mon, 17 Aug 2020 01:11:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 531701C11C; Mon, 17 Aug 2020 01:11:14 +0200 (CEST) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 0EF5D1C11B for ; Mon, 17 Aug 2020 01:11:12 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id g15so2686767plj.6 for ; Sun, 16 Aug 2020 16:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=G+BVVfZVudXe0H1MH/ijx+MchTUNTOowiPDa2OCrNAY=; b=pghXxAOGLjbO6ksrCNcrTSTbl2ZTjFa1BLB/V7YxnjimnGlWRrs5eU4PRqAqNVgW1P lbidhpCjgE70vvsb0HditVAt7MGvSwi6ZKrkTffeBrH8VeLMYyosd6Yr4x5uRZTOdreh bykF+LhlmhJyzROiWSfRZTpS5SWrbGwslR80icMEJTozb3Y8onPRFtjnmxjo4Dgrs5NY BOfQB2+sD1YGmSsj0WYBDd5ssJLgHkmqxlMHe7CQbgOUHnUxbAgWH9v1SLogQnTKJeHu OIvUIrRRA0tZxON2eNC/I/6Ck07mA53PP1B5zKQPSekDYPV3iu4MNwBMe31/QHNX6CRS xhFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=G+BVVfZVudXe0H1MH/ijx+MchTUNTOowiPDa2OCrNAY=; b=f4mDWkzGs2HpGCujt9SaEo7ic3UetNyzdpUu7zD+wlqdNdwAk3o7SN+bdzue4mBLwx Nqlps/Wpq0+cmig7nZJzYKB7J+I3CGagfSqHJmEz1uqPrJtX8SnLGFJ8us2+w3b3vJkm FLwtWCom7KTqMr8fYgHT7hzSuY5lJlZDFDvOZzLELmU0I1/mMzd2Fmr99J8K7aa5QR7/ 3y3EI4/J+TwI1FAhN/J2earlfnGeuZzCWUQ73JYO50GQwjohZYl1Hm7Un0HdrqMZMISi PKpaNjEe6bQB8t3NOa9x64I22/2X9HkWYETHbYtvqRgUUUWn8ImciweFj7ySPaTzRwqY iG2w== X-Gm-Message-State: AOAM531BiqUpuT5mTAJe0XPFtM0mG2l3f4eO4JJELD2ngtRznZ1DxO+Y d1XJtJ5MAuh2WFWWXnzUHacRLQ== X-Google-Smtp-Source: ABdhPJyTxqLnpmOxqmZdjweKfzCYArb3EevgVpGXJzI0w55bLJ+Sw22udXRrq0LKniOb+Mvvxo82WA== X-Received: by 2002:a17:90a:cf95:: with SMTP id i21mr10217531pju.135.1597619472009; Sun, 16 Aug 2020 16:11:12 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id o134sm16426402pfg.200.2020.08.16.16.11.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Aug 2020 16:11:11 -0700 (PDT) Date: Sun, 16 Aug 2020 16:11:03 -0700 From: Stephen Hemminger To: longli@linuxonhyperv.com Cc: "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , dev@dpdk.org, Long Li , stable@dpdk.org Message-ID: <20200816161103.1e7473a6@hermes.lan> In-Reply-To: <1597113194-90208-1-git-send-email-longli@linuxonhyperv.com> References: <1597113194-90208-1-git-send-email-longli@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/4] net/netvsc: move rxbuf_info from per-device to per-queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 10 Aug 2020 19:33:11 -0700 longli@linuxonhyperv.com wrote: > From: Long Li > > netvsc uses rxbuf_info buffer to track received packets attached via > rte_pktmbuf_attach_extbuf() and ack the host based on usage count. It uses > the transaction_id in the VMBus packet to locate where to use memory in the > rxbuf_info. > > This is not correct in multiple channel setup, as different channels may > return idential transaction_ids at a time, and may corrupt the rxbuf_info > buffer. > > Fix this by defining rxbuf_info for each queue. > > Fixes: 4e9c73e96 ("net/netvsc: add Hyper-V network device") > Cc: stable@dpdk.org > Signed-off-by: Long Li Acked-by: Stephen Hemminger