From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6E6EA0351; Mon, 17 Aug 2020 12:37:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DC3741C0D9; Mon, 17 Aug 2020 12:37:50 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 85CEB1C020 for <dev@dpdk.org>; Mon, 17 Aug 2020 12:37:49 +0200 (CEST) IronPort-SDR: bLIE1X57wLICUelgQ+eQ0UGRSfOYQTVD1M1H4fgmB1sbCM7uG/KO98J/GRamF0FlPRVHcWQTA3 8NkMjzQpHufA== X-IronPort-AV: E=McAfee;i="6000,8403,9715"; a="155767315" X-IronPort-AV: E=Sophos;i="5.76,322,1592895600"; d="scan'208";a="155767315" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2020 03:37:47 -0700 IronPort-SDR: P6yZX3PfV8dBT/gbMjPbM0WcKQU8Gl7VjwLoFSEqIqB7sNDySC7JLC7pKBJsEluuqejOQynbHD 1Gvlr+7ox8ug== X-IronPort-AV: E=Sophos;i="5.76,322,1592895600"; d="scan'208";a="471380848" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.17.138]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 17 Aug 2020 03:37:45 -0700 Date: Mon, 17 Aug 2020 11:37:40 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: Stephen Hemminger <stephen@networkplumber.org> Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, dev@dpdk.org Message-ID: <20200817103740.GA496@bricha3-MOBL.ger.corp.intel.com> References: <20200814173441.23086-1-stephen@networkplumber.org> <20200814213929.1d7ca040@sovereign> <20200814114549.528d144f@hermes.lan> <20200814220911.39097cfa@sovereign> <20200814122028.312c7c8b@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200814122028.312c7c8b@hermes.lan> Subject: Re: [dpdk-dev] [PATCH] eal: add option to put timestamp on console output X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Fri, Aug 14, 2020 at 12:20:28PM -0700, Stephen Hemminger wrote: > On Fri, 14 Aug 2020 22:09:11 +0300 > Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote: > > > On Fri, 14 Aug 2020 11:45:49 -0700, Stephen Hemminger wrote: > > > On Fri, 14 Aug 2020 21:39:29 +0300 > > > Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote: > > [...] > > > FreeBsd doesn't go through the same log code. > > > > Then --log-timestamp shouldn't appear on FreeBSD if it's unsupported. > > Was using same ifdef that is already there. There are several options already > (like syslog facility) which do nothing on FreeBSD anyway. > While that is correct, I think that we really should support this on FreeBSD also, since I don't think there is any technical reason we can't do so, right? Even a sub-optimal solution where the timestamp write and log write are non-atomic would be better than nothing. /Bruce