From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc/guides: remove dependency on make build system
Date: Thu, 20 Aug 2020 16:54:20 +0100 [thread overview]
Message-ID: <20200820155420.GB824@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20200722125949.GA1031@bricha3-MOBL.ger.corp.intel.com>
On Wed, Jul 22, 2020 at 01:59:49PM +0100, Bruce Richardson wrote:
> On Wed, Jul 22, 2020 at 02:45:54PM +0200, Thomas Monjalon wrote:
> > 21/07/2020 17:39, Bruce Richardson:
> > > When building the DPDK guide documents, the DPDK version information was
> > > pulled using "make showversion", which meant there was a dependency on
> > > the DPDK make-based build system. Change this to just read the data from
> > > the VERSION file in the root directory.
> > >
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > ---
> > > NOTE: When make build system is completed removed, we can change the
> > > relative path to the VERSION file i.e. "../../", to instead pull the
> > > path from "MESON_SOURCE_ROOT" in the environment, which should be more
> > > robust.
> >
> > Yes it would be a bit better.
> > If we merge this patch in 20.08, we'll forget about this improvement :)
> > I suggest waiting 20.11 to merge the definitive improvement.
> >
> I'd prefer now, but I can be patient, I suppose. :-)
Updated and improved version of this patch is now part of the "make
removal" patch series. Marking this standalone patch as superceded.
/Bruce
prev parent reply other threads:[~2020-08-20 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 15:39 Bruce Richardson
2020-07-21 15:42 ` Bruce Richardson
2020-07-22 12:45 ` Thomas Monjalon
2020-07-22 12:59 ` Bruce Richardson
2020-08-20 15:54 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820155420.GB824@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).