From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7434A04AF; Fri, 21 Aug 2020 11:41:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9C39D4CA6; Fri, 21 Aug 2020 11:41:14 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id CEC402C02 for ; Fri, 21 Aug 2020 11:41:11 +0200 (CEST) IronPort-SDR: Ef4zwiKlcY4okLimwCddQn3tjSkv4gzjmfajhMfH4BbMZ3Ng/X3o8pJ42Gs2WUbWWkKvr1m/IP V7bEjfe9csIA== X-IronPort-AV: E=McAfee;i="6000,8403,9719"; a="156551443" X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="156551443" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2020 02:41:10 -0700 IronPort-SDR: g/YWNVRSL/2eLspDyCy9cijIXeT+obOzgTREDH4B2AOpEzmf0qFl4cNvVDqF9e2jmFWTH3u9Vc 5/QHZvQUFTIg== X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="472988983" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.0.70]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 21 Aug 2020 02:41:09 -0700 Date: Fri, 21 Aug 2020 10:41:06 +0100 From: Bruce Richardson To: "Chautru, Nicolas" Cc: "Power, Ciara" , "dev@dpdk.org" , "Mcnamara, John" , "Kovacevic, Marko" Message-ID: <20200821094106.GB841@bricha3-MOBL.ger.corp.intel.com> References: <20200807123009.21266-1-ciara.power@intel.com> <20200820124140.13451-1-ciara.power@intel.com> <20200820124140.13451-21-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v2 20/37] doc: remove references to make in bbdev guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Aug 21, 2020 at 02:22:14AM +0000, Chautru, Nicolas wrote: > From: Power, Ciara > > Make is no longer supported for compiling DPDK, references are now removed > > in the documentation. > > > > Reviewed-by: Kevin Laatz > > Signed-off-by: Ciara Power > > --- > > doc/guides/bbdevs/fpga_5gnr_fec.rst | 7 ++----- > > doc/guides/bbdevs/fpga_lte_fec.rst | 7 ++----- > > doc/guides/bbdevs/turbo_sw.rst | 15 --------------- > > 3 files changed, 4 insertions(+), 25 deletions(-) > > > > diff --git a/doc/guides/bbdevs/fpga_5gnr_fec.rst > > b/doc/guides/bbdevs/fpga_5gnr_fec.rst > > index 6760391e8c..8e00c4ef22 100644 > > --- a/doc/guides/bbdevs/fpga_5gnr_fec.rst > > +++ b/doc/guides/bbdevs/fpga_5gnr_fec.rst > > @@ -51,10 +51,7 @@ FPGA 5GNR FEC does not support the following: > > Installation > > ------------ > > > > -Section 3 of the DPDK manual provides instructions on installing and compiling > > DPDK. The -default set of bbdev compile flags may be found in > > config/common_base, where for example -the flag to build the FPGA 5GNR FEC > > device, ``CONFIG_RTE_LIBRTE_PMD_BBDEV_FPGA_5GNR_FEC``, > > -is already set. > > +Section 3 of the DPDK manual provides instructions on installing and compiling > > DPDK. > > > > DPDK requires hugepages to be configured as detailed in section 2 of the DPDK > > manual. > > The bbdev test application has been tested with a configuration 40 x 1GB > > hugepages. The @@ -94,7 +91,7 @@ the UIO driver by repeating this > > command for every function. > > .. code-block:: console > > > > cd > > - insmod ./build/kmod/igb_uio.ko > > + insmod .//kernel/linux/igb_uio/igb_uio.ko > > echo "8086 0d8f" > /sys/bus/pci/drivers/igb_uio/new_id > > lspci -vd8086:0d8f > > > > diff --git a/doc/guides/bbdevs/fpga_lte_fec.rst > > b/doc/guides/bbdevs/fpga_lte_fec.rst > > index fdc8a76981..14ffa0ee14 100644 > > --- a/doc/guides/bbdevs/fpga_lte_fec.rst > > +++ b/doc/guides/bbdevs/fpga_lte_fec.rst > > @@ -50,10 +50,7 @@ FPGA LTE FEC does not support the following: > > Installation > > -------------- > > > > -Section 3 of the DPDK manual provides instructions on installing and compiling > > DPDK. The -default set of bbdev compile flags may be found in > > config/common_base, where for example -the flag to build the FPGA LTE FEC > > device, ``CONFIG_RTE_LIBRTE_PMD_BBDEV_FPGA_LTE_FEC``, is already -set. > > +Section 3 of the DPDK manual provides instructions on installing and compiling > > DPDK. > > > > DPDK requires hugepages to be configured as detailed in section 2 of the DPDK > > manual. > > The bbdev test application has been tested with a configuration 40 x 1GB > > hugepages. The @@ -93,7 +90,7 @@ the UIO driver by repeating this > > command for every function. > > .. code-block:: console > > > > cd > > - insmod ./build/kmod/igb_uio.ko > > + insmod .//kernel/linux/igb_uio/igb_uio.ko > > echo "1172 5052" > /sys/bus/pci/drivers/igb_uio/new_id > > lspci -vd1172: > > > > diff --git a/doc/guides/bbdevs/turbo_sw.rst b/doc/guides/bbdevs/turbo_sw.rst > > index 20620c2e20..3b93157890 100644 > > --- a/doc/guides/bbdevs/turbo_sw.rst > > +++ b/doc/guides/bbdevs/turbo_sw.rst > > @@ -12,14 +12,6 @@ Note that the driver can also be built without any > > dependency with reduced functionality for maintenance purpose. > > > > To enable linking to the SDK libraries see detailed installation section below. > > -Two flags can be enabled depending on whether the target machine can > > support > > -AVX2 and AVX512 instructions sets and the related SDK libraries for vectorized > > -signal processing functions are installed : > > -- CONFIG_RTE_BBDEV_SDK_AVX2 > > -- CONFIG_RTE_BBDEV_SDK_AVX512 > > -By default these 2 flags are disabled by default. For AVX2 machine and SDK - > > library installed then the first flag can be enabled. For AVX512 machine and - > > SDK library installed then both flags can be enabled for full real time capability. > > Hi, > We are losing information here. Even if the configuration options should not be documented based on an explicit reference make and config_base assumptions (agreed that they are no longer there), the steps should still capture the conf to be passed to meson so that the PMD can still be built with the avx2/avx512 intel libraries (ie. not the case by default due to additional dependency to retrieve the related libraries). > Thanks > Nic Hi Nic, Can you perhaps suggest the appropriate wording to use? Given the size of the patchset, I think we need individual maintainers to help provide the appropriate doc adjustments. Thanks, /Bruce