From: Bruce Richardson <bruce.richardson@intel.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>,
Nipun Gupta <nipun.gupta@nxp.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH 2/4] raw/ioat: include extra info in error messages
Date: Fri, 21 Aug 2020 16:59:43 +0100 [thread overview]
Message-ID: <20200821155945.29415-3-bruce.richardson@intel.com> (raw)
In-Reply-To: <20200821155945.29415-1-bruce.richardson@intel.com>
In case of any failures, include the function name and the line number of
the error message in the message, to make tracking down the failure easier.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/raw/ioat/ioat_rawdev_test.c | 52 +++++++++++++++++++----------
1 file changed, 34 insertions(+), 18 deletions(-)
diff --git a/drivers/raw/ioat/ioat_rawdev_test.c b/drivers/raw/ioat/ioat_rawdev_test.c
index 6262995256..534b07b124 100644
--- a/drivers/raw/ioat/ioat_rawdev_test.c
+++ b/drivers/raw/ioat/ioat_rawdev_test.c
@@ -17,6 +17,22 @@ int ioat_rawdev_test(uint16_t dev_id); /* pre-define to keep compiler happy */
static struct rte_mempool *pool;
static unsigned short expected_ring_size[MAX_SUPPORTED_RAWDEVS];
+#define PRINT_ERR(...) print_err(__func__, __LINE__, __VA_ARGS__)
+
+static inline int
+print_err(const char *func, int lineno, const char *format, ...)
+{
+ va_list ap;
+ int ret;
+
+ ret = fprintf(stderr, "In %s:%d - ", func, lineno);
+ va_start(ap, format);
+ ret += vfprintf(stderr, format, ap);
+ va_end(ap);
+
+ return ret;
+}
+
static int
test_enqueue_copies(int dev_id)
{
@@ -46,7 +62,7 @@ test_enqueue_copies(int dev_id)
(uintptr_t)src,
(uintptr_t)dst,
0 /* no fence */) != 1) {
- printf("Error with rte_ioat_enqueue_copy\n");
+ PRINT_ERR("Error with rte_ioat_enqueue_copy\n");
return -1;
}
rte_ioat_do_copies(dev_id);
@@ -54,18 +70,18 @@ test_enqueue_copies(int dev_id)
if (rte_ioat_completed_copies(dev_id, 1, (void *)&completed[0],
(void *)&completed[1]) != 1) {
- printf("Error with rte_ioat_completed_copies\n");
+ PRINT_ERR("Error with rte_ioat_completed_copies\n");
return -1;
}
if (completed[0] != src || completed[1] != dst) {
- printf("Error with completions: got (%p, %p), not (%p,%p)\n",
+ PRINT_ERR("Error with completions: got (%p, %p), not (%p,%p)\n",
completed[0], completed[1], src, dst);
return -1;
}
for (i = 0; i < length; i++)
if (dst_data[i] != src_data[i]) {
- printf("Data mismatch at char %u\n", i);
+ PRINT_ERR("Data mismatch at char %u\n", i);
return -1;
}
rte_pktmbuf_free(src);
@@ -98,7 +114,7 @@ test_enqueue_copies(int dev_id)
(uintptr_t)srcs[i],
(uintptr_t)dsts[i],
0 /* nofence */) != 1) {
- printf("Error with rte_ioat_enqueue_copy for buffer %u\n",
+ PRINT_ERR("Error with rte_ioat_enqueue_copy for buffer %u\n",
i);
return -1;
}
@@ -108,18 +124,18 @@ test_enqueue_copies(int dev_id)
if (rte_ioat_completed_copies(dev_id, 64, (void *)completed_src,
(void *)completed_dst) != RTE_DIM(srcs)) {
- printf("Error with rte_ioat_completed_copies\n");
+ PRINT_ERR("Error with rte_ioat_completed_copies\n");
return -1;
}
for (i = 0; i < RTE_DIM(srcs); i++) {
char *src_data, *dst_data;
if (completed_src[i] != srcs[i]) {
- printf("Error with source pointer %u\n", i);
+ PRINT_ERR("Error with source pointer %u\n", i);
return -1;
}
if (completed_dst[i] != dsts[i]) {
- printf("Error with dest pointer %u\n", i);
+ PRINT_ERR("Error with dest pointer %u\n", i);
return -1;
}
@@ -127,7 +143,7 @@ test_enqueue_copies(int dev_id)
dst_data = rte_pktmbuf_mtod(dsts[i], char *);
for (j = 0; j < length; j++)
if (src_data[j] != dst_data[j]) {
- printf("Error with copy of packet %u, byte %u\n",
+ PRINT_ERR("Error with copy of packet %u, byte %u\n",
i, j);
return -1;
}
@@ -160,26 +176,26 @@ ioat_rawdev_test(uint16_t dev_id)
rte_rawdev_info_get(dev_id, &info, sizeof(p));
if (p.ring_size != expected_ring_size[dev_id]) {
- printf("Error, initial ring size is not as expected (Actual: %d, Expected: %d)\n",
+ PRINT_ERR("Error, initial ring size is not as expected (Actual: %d, Expected: %d)\n",
(int)p.ring_size, expected_ring_size[dev_id]);
return -1;
}
p.ring_size = IOAT_TEST_RINGSIZE;
if (rte_rawdev_configure(dev_id, &info, sizeof(p)) != 0) {
- printf("Error with rte_rawdev_configure()\n");
+ PRINT_ERR("Error with rte_rawdev_configure()\n");
return -1;
}
rte_rawdev_info_get(dev_id, &info, sizeof(p));
if (p.ring_size != IOAT_TEST_RINGSIZE) {
- printf("Error, ring size is not %d (%d)\n",
+ PRINT_ERR("Error, ring size is not %d (%d)\n",
IOAT_TEST_RINGSIZE, (int)p.ring_size);
return -1;
}
expected_ring_size[dev_id] = p.ring_size;
if (rte_rawdev_start(dev_id) != 0) {
- printf("Error with rte_rawdev_start()\n");
+ PRINT_ERR("Error with rte_rawdev_start()\n");
return -1;
}
@@ -190,7 +206,7 @@ ioat_rawdev_test(uint16_t dev_id)
2048, /* data room size */
info.socket_id);
if (pool == NULL) {
- printf("Error with mempool creation\n");
+ PRINT_ERR("Error with mempool creation\n");
return -1;
}
@@ -199,14 +215,14 @@ ioat_rawdev_test(uint16_t dev_id)
snames = malloc(sizeof(*snames) * nb_xstats);
if (snames == NULL) {
- printf("Error allocating xstat names memory\n");
+ PRINT_ERR("Error allocating xstat names memory\n");
goto err;
}
rte_rawdev_xstats_names_get(dev_id, snames, nb_xstats);
ids = malloc(sizeof(*ids) * nb_xstats);
if (ids == NULL) {
- printf("Error allocating xstat ids memory\n");
+ PRINT_ERR("Error allocating xstat ids memory\n");
goto err;
}
for (i = 0; i < nb_xstats; i++)
@@ -214,7 +230,7 @@ ioat_rawdev_test(uint16_t dev_id)
stats = malloc(sizeof(*stats) * nb_xstats);
if (stats == NULL) {
- printf("Error allocating xstat memory\n");
+ PRINT_ERR("Error allocating xstat memory\n");
goto err;
}
@@ -234,7 +250,7 @@ ioat_rawdev_test(uint16_t dev_id)
rte_rawdev_stop(dev_id);
if (rte_rawdev_xstats_reset(dev_id, NULL, 0) != 0) {
- printf("Error resetting xstat values\n");
+ PRINT_ERR("Error resetting xstat values\n");
goto err;
}
--
2.25.1
next prev parent reply other threads:[~2020-08-21 16:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 15:59 [dpdk-dev] [PATCH 0/4] simplify unit-testing of rawdevs Bruce Richardson
2020-08-21 15:59 ` [dpdk-dev] [PATCH 1/4] raw/ioat: support multiple devices being tested Bruce Richardson
2020-08-21 15:59 ` Bruce Richardson [this message]
2020-08-21 15:59 ` [dpdk-dev] [PATCH 3/4] app/test: change rawdev autotest to run selftest on all devs Bruce Richardson
2020-08-21 15:59 ` [dpdk-dev] [PATCH 4/4] app/test: remove ioat-specific autotest Bruce Richardson
2020-09-10 16:47 ` [dpdk-dev] [PATCH v2 0/3] simplify unit-testing of rawdevs Bruce Richardson
2020-09-10 16:47 ` [dpdk-dev] [PATCH v2 1/3] raw/ioat: support multiple devices being tested Bruce Richardson
2020-09-14 12:34 ` Laatz, Kevin
2020-09-10 16:47 ` [dpdk-dev] [PATCH v2 2/3] app/test: change rawdev autotest to run selftest on all devs Bruce Richardson
2020-09-14 12:28 ` Laatz, Kevin
2020-09-10 16:47 ` [dpdk-dev] [PATCH v2 3/3] app/test: remove ioat-specific autotest Bruce Richardson
2020-09-14 12:31 ` Laatz, Kevin
2020-10-06 7:28 ` [dpdk-dev] [PATCH v2 0/3] simplify unit-testing of rawdevs Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821155945.29415-3-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=nipun.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).