From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBC23A04AC; Mon, 24 Aug 2020 16:40:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 376ADFEB; Mon, 24 Aug 2020 16:40:53 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 3F093F90 for ; Mon, 24 Aug 2020 16:40:51 +0200 (CEST) IronPort-SDR: 1kFxBa6TpRvKAUUwDFSfUJApupEqxrNkmRHLclmJQ9PxDkgSfCsgTx0PuMkIFIx2jlZJNH2zSn 05ndN+2/H9Sg== X-IronPort-AV: E=McAfee;i="6000,8403,9722"; a="156962031" X-IronPort-AV: E=Sophos;i="5.76,349,1592895600"; d="scan'208";a="156962031" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2020 07:40:50 -0700 IronPort-SDR: emjG+sD5U1EMGIjpgkyAoEOveOVfS4+GjSM/TAbEpKwHYhLR0+oStxio4CHQOlY2s9pCx/PgOS +pfnkgqLr3jw== X-IronPort-AV: E=Sophos;i="5.76,349,1592895600"; d="scan'208";a="499493291" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.20.200]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 24 Aug 2020 07:40:48 -0700 Date: Mon, 24 Aug 2020 15:40:45 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: Ed Czeck , dev@dpdk.org, shepard.siegel@atomicrules.com, john.miller@atomicrules.com Message-ID: <20200824144045.GA547@bricha3-MOBL.ger.corp.intel.com> References: <20200819153539.32698-1-ed.czeck@atomicrules.com> <20200824133641.19450-1-ed.czeck@atomicrules.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH 1/2] net/ark: remove compile time log macros in favor of run time log control X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Aug 24, 2020 at 03:37:53PM +0100, Ferruh Yigit wrote: > On 8/24/2020 2:36 PM, Ed Czeck wrote: > > Use ARK_PMD_LOG in place of PMD_DRV_LOG, PMD_DEBUG_LOG, PMD_FUNC_LOG, > > PMD_STATS_LOG, PMD_RX_LOG, and PMD_TX_LOG. > > Review and adjust log levels and messages as needed. > > > > Signed-off-by: Ed Czeck > > --- > > doc/guides/nics/ark.rst | 13 ------ > > drivers/net/ark/ark_ddm.c | 12 ++--- > > drivers/net/ark/ark_ethdev.c | 77 +++++++++++++++------------------ > > drivers/net/ark/ark_ethdev_rx.c | 46 ++++++++++---------- > > drivers/net/ark/ark_ethdev_tx.c | 10 ++--- > > drivers/net/ark/ark_logs.h | 63 +++------------------------ > > drivers/net/ark/ark_mpu.c | 32 ++++---------- > > drivers/net/ark/ark_pktchkr.c | 36 +++++++-------- > > drivers/net/ark/ark_pktdir.c | 2 +- > > drivers/net/ark/ark_pktgen.c | 22 +++++----- > > drivers/net/ark/ark_rqp.c | 4 +- > > drivers/net/ark/ark_udm.c | 18 ++++---- > > 12 files changed, 125 insertions(+), 210 deletions(-) > > > > diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst > > index 06e8c3374..c3ffcbbc2 100644 > > --- a/doc/guides/nics/ark.rst > > +++ b/doc/guides/nics/ark.rst > > @@ -132,19 +132,6 @@ Configuration Information > > * **CONFIG_RTE_LIBRTE_ARK_PAD_TX** (default y): When enabled TX > > packets are padded to 60 bytes to support downstream MACS. > > > > - * **CONFIG_RTE_LIBRTE_ARK_DEBUG_RX** (default n): Enables or disables debug > > - logging and internal checking of RX ingress logic within the ARK PMD driver. > > - > > - * **CONFIG_RTE_LIBRTE_ARK_DEBUG_TX** (default n): Enables or disables debug > > - logging and internal checking of TX egress logic within the ARK PMD driver. > > - > > - * **CONFIG_RTE_LIBRTE_ARK_DEBUG_STATS** (default n): Enables or disables debug > > - logging of detailed packet and performance statistics gathered in > > - the PMD and FPGA. > > - > > - * **CONFIG_RTE_LIBRTE_ARK_DEBUG_TRACE** (default n): Enables or disables debug > > - logging of detailed PMD events and status. > > - > > Can you please remove these config option from 'config/common_base'? > Given that the file is scheduled for deletion fairly soon, not sure if that is worthwhile doing.