From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 74E79A04B1;
Thu, 27 Aug 2020 18:15:25 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 5955A1C11E;
Thu, 27 Aug 2020 18:13:53 +0200 (CEST)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
by dpdk.org (Postfix) with ESMTP id 98A451C0B2
for <dev@dpdk.org>; Thu, 27 Aug 2020 18:13:41 +0200 (CEST)
IronPort-SDR: vN5ScbwME8E/Tbm4IQk0KRZ5QO3xQekftEoWZFCToNDghF05zD9Xs5+nV8vI9KhIFlv864nLc1
lYvSWUH6LUaw==
X-IronPort-AV: E=McAfee;i="6000,8403,9726"; a="220767034"
X-IronPort-AV: E=Sophos;i="5.76,360,1592895600"; d="scan'208";a="220767034"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
27 Aug 2020 09:13:31 -0700
IronPort-SDR: 0vuwzSq7nHeOimbsBPqmxhc2lzQpr59Bb7fQmBEqHZwOksKrMP1B0/A02qtssb1L3vmKfTDoAU
Gw1lW/CZ0Cng==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.76,360,1592895600"; d="scan'208";a="280681532"
Received: from silpixa00399953.ir.intel.com (HELO
silpixa00399953.ger.corp.intel.com) ([10.237.222.53])
by fmsmga007.fm.intel.com with ESMTP; 27 Aug 2020 09:13:30 -0700
From: Ciara Power <ciara.power@intel.com>
To: dev@dpdk.org
Cc: Ciara Power <ciara.power@intel.com>, Wei Zhao <wei.zhao1@intel.com>,
Jeff Guo <jia.guo@intel.com>
Date: Thu, 27 Aug 2020 17:12:58 +0100
Message-Id: <20200827161304.32300-12-ciara.power@intel.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20200827161304.32300-1-ciara.power@intel.com>
References: <20200807155859.63888-1-ciara.power@intel.com>
<20200827161304.32300-1-ciara.power@intel.com>
Subject: [dpdk-dev] [PATCH v2 11/17] net/ixgbe: add checks for max SIMD
bitwidth
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
When choosing a vector path to take, an extra condition must be
satisfied to ensure the max SIMD bitwidth allows for the CPU enabled
path.
Cc: Wei Zhao <wei.zhao1@intel.com>
Cc: Jeff Guo <jia.guo@intel.com>
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
drivers/net/ixgbe/ixgbe_rxtx.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index 977ecf5137..eadc7183f2 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -2503,7 +2503,9 @@ ixgbe_set_tx_function(struct rte_eth_dev *dev, struct ixgbe_tx_queue *txq)
dev->tx_pkt_prepare = NULL;
if (txq->tx_rs_thresh <= RTE_IXGBE_TX_MAX_FREE_BUF_SZ &&
(rte_eal_process_type() != RTE_PROC_PRIMARY ||
- ixgbe_txq_vec_setup(txq) == 0)) {
+ ixgbe_txq_vec_setup(txq) == 0) &&
+ rte_get_max_simd_bitwidth()
+ >= RTE_MAX_128_SIMD) {
PMD_INIT_LOG(DEBUG, "Vector tx enabled.");
dev->tx_pkt_burst = ixgbe_xmit_pkts_vec;
} else
@@ -4743,7 +4745,8 @@ ixgbe_set_rx_function(struct rte_eth_dev *dev)
* conditions to be met and Rx Bulk Allocation should be allowed.
*/
if (ixgbe_rx_vec_dev_conf_condition_check(dev) ||
- !adapter->rx_bulk_alloc_allowed) {
+ !adapter->rx_bulk_alloc_allowed ||
+ rte_get_max_simd_bitwidth() < RTE_MAX_128_SIMD) {
PMD_INIT_LOG(DEBUG, "Port[%d] doesn't meet Vector Rx "
"preconditions",
dev->data->port_id);
--
2.17.1