From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 7FD9CA04AC;
Tue, 1 Sep 2020 04:23:33 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id C5EBC1C0D2;
Tue, 1 Sep 2020 04:23:32 +0200 (CEST)
Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com
[209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 8D8901C0D0
for <dev@dpdk.org>; Tue, 1 Sep 2020 04:23:31 +0200 (CEST)
Received: by mail-pg1-f196.google.com with SMTP id w186so1811508pgb.8
for <dev@dpdk.org>; Mon, 31 Aug 2020 19:23:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=anbHTKiLwgpwTQ5v/U2mkwXQt5WCr73BIgVYa+BsJAQ=;
b=SVWgsEPnbN+tdrHzuQpDZuZzuaqCGnWO9DVlJ9HZdGSKLCPOxhK40QG1zTC1lhldZh
BVSVgaDvVum7onckvTsu7UYAsmisKCBd/SHvlD+KMir4cLFOI/WEb/4WmJHEIYP/TLXC
mH+IE8W5eloLi5odMuGfXUocmLHEQ582JR455Ux9uMBGjfb2p5B8N3PGpAUTx0uSiWig
iN1/X7gObn8mnvHcoVhjiU6VBUKYMuJckAg+5N6zEOcXPCWmrKdSx7tPyxXg1PSOjKIb
n/QG8a77gWdzBWRpAUVmZKMx6WPHl9gRFKmezswJcylksp2Gne61jL526BYkQYb30rRm
9Nfg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=anbHTKiLwgpwTQ5v/U2mkwXQt5WCr73BIgVYa+BsJAQ=;
b=QwnN6R+y1EE4feeO6DwTM4brz0O4Oi4NVjGvotB6sgm44cS7SqqsDAKkS+EMQiRyEU
IhpjOpwyZTuuAzN3XDACdLTY8f+toGLWXFZBC9jFL96j0Qc94SSdj4oPYyAGKkt+437b
UBAndgUsoECjuXW8cLOLvCehBOrgVNv7zSO/apfQVHhlbt+tzWGJK1Ov8+5NFrqKzWbE
QOX+gQfIGFksKCNRxMgkEhVoXs9umgcuRngi5QWB9trAArpTfsTP4BjP7jKyIyNeU4pP
SpjhJD7BKXV6THLmKPMRf92czEqCCCi+xErPfPuhLLHeaWT2gVTlQPZoqUAAt6rL3GvA
NPSQ==
X-Gm-Message-State: AOAM5318+kxKkZzkZLKDz17NcNUKsqfl3q/r/TEk7BMOTC7bwHc2JcEA
zCPAlxBZlUCLMQXUyhvBOmFmrw==
X-Google-Smtp-Source: ABdhPJyJjPfX5gUKnA90D8D4s+J0D3Rjn55GOdGkvAzF2FjYrCNa05X246JNFPgY84BXy8zpKVhWvg==
X-Received: by 2002:a65:6286:: with SMTP id f6mr3714259pgv.0.1598927010349;
Mon, 31 Aug 2020 19:23:30 -0700 (PDT)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
by smtp.gmail.com with ESMTPSA id m24sm8972107pgn.44.2020.08.31.19.23.29
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 31 Aug 2020 19:23:29 -0700 (PDT)
Date: Mon, 31 Aug 2020 19:23:21 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: <dev@dpdk.org>, <ferruh.yigit@intel.com>, <bruce.richardson@intel.com>,
<jerin.jacob@caviumnetworks.com>, <john.mcnamara@intel.com>,
<alvinx.zhang@intel.com>, <thomas.monjalon@6wind.com>,
<linuxarm@huawei.com>
Message-ID: <20200831192321.422a2e86@hermes.lan>
In-Reply-To: <1598923998-44155-2-git-send-email-humin29@huawei.com>
References: <1598845317-55956-1-git-send-email-humin29@huawei.com>
<1598923998-44155-1-git-send-email-humin29@huawei.com>
<1598923998-44155-2-git-send-email-humin29@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [RFC 2/2] ethdev: fix compiling errors for per-queue
statistics
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Tue, 1 Sep 2020 09:33:18 +0800
"Min Hu (Connor)" <humin29@huawei.com> wrote:
> From: Huisong Li <lihuisong@huawei.com>
>
> Currently, only statistics of rx/tx queues with queue_id less than
> RTE_ETHDEV_QUEUE_STAT_CNTRS can be displayed. If there is a certain
> application scenario that it needs to use 256 or more than 256 queues
> and display all statistics of rx/tx queue. At this moment, we have to
> change the macro to be equaled to the queue number.
>
> However, modifying the macro to be greater than 256 will trigger
> many errors and warnings from test-pmd, PMD driver and librte_ethdev
> during compiling dpdk project. But it is possible and permited that
> rx/tx queue number is greater than 256 and all statistics of rx/tx
> queue need to be displayed. In addition, the data type of rx/tx queue
> number in rte_eth_dev_configure API is 'uint16_t'. So It is unreasonable
> to use the 'uint8_t' type for variables that control which per-queue
> statistics can be displayed.
>
> Fixes: ed30d9b691b2 ("app/testpmd: add stats per queue")
> Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD")
> Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/")
> Fixes: e6defdfddc3b ("net/igc: enable statistics")
> Fixes: 2265e4b4e84b ("net/octeontx2: add basic stats operation")
> Fixes: 6c3169a3dc04 ("virtio: move to drivers/net/")
> Cc: stable@dpdk.org
>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Reviewed-by: huwei <xavier.huwei@huawei.com>
> Reviewed-by: liudongdong <liudongdong3@huawei.com>
> ---
This looks like a reasonable way to address this.
But it does break the API, and it wasn't announced previously.
Since it is minor and compatible change I am ok with doing it for 20.11.
Please update the release notes.