From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F825A04AC; Tue, 1 Sep 2020 11:02:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DA2EBE07; Tue, 1 Sep 2020 11:02:49 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3B127CF3 for ; Tue, 1 Sep 2020 11:02:47 +0200 (CEST) IronPort-SDR: fmQS8mSPSlHlXiwperrs/2I8UW7+JmoPY6iprj39fHSfYEv7FG6s4MOifuGnTGNMhTQxqFTXY1 Ful+3y6efNRA== X-IronPort-AV: E=McAfee;i="6000,8403,9730"; a="154532445" X-IronPort-AV: E=Sophos;i="5.76,378,1592895600"; d="scan'208";a="154532445" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2020 02:02:46 -0700 IronPort-SDR: G0mYi6daCX2IfACRZ70vXqPCTtRj3m+TPoTojyeoiEFADj+9jnrPYTcv88JMvHYGrZxW2rRQ23 CkbJd5oj7/hA== X-IronPort-AV: E=Sophos;i="5.76,378,1592895600"; d="scan'208";a="477119023" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.80.162]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 01 Sep 2020 02:02:44 -0700 Date: Tue, 1 Sep 2020 10:02:41 +0100 From: Bruce Richardson To: Hemant Agrawal Cc: "Ma, LihongX" , "dev@dpdk.org" , "bluca@debian.org" Message-ID: <20200901090241.GA1047@bricha3-MOBL.ger.corp.intel.com> References: <20200825114447.135030-1-bruce.richardson@intel.com> <20200825114447.135030-2-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH 2/2] config: allow overriding some build defaults X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 01, 2020 at 06:07:56AM +0000, Hemant Agrawal wrote: > HI Bruce, > Will you please also add similar command examples in docs so that it becomes easy for the developers to use meson? > > Regards, > Hemant > I'll add a note in somewhere, but this is probably not something that we want to be advertising too much. We are trying to move away from build-time config so we want the defaults to be sane and try and avoid developers asking the end-user to compile up DPDK with magic flags. That said, it should be possible, and documented. :-) /Bruce > -----Original Message----- > From: dev On Behalf Of Ma, LihongX > Sent: Tuesday, September 1, 2020 10:48 AM > To: Richardson, Bruce ; dev@dpdk.org > Cc: bluca@debian.org; Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH 2/2] config: allow overriding some build defaults > > Tested-by: lihongx Ma Before apply this patchset, set config like DRTE_LIBRTE_I40E_QUEUE_NUM_PER_VM=8 will failed, After apply this patchset, the the meson build can work find. > Cmd like below: > meson -Denable_kmods=True -Dlibdir=lib --default-library=static -Dexamples=vmdq_dcb -Dc_args='-DRTE_LIBRTE_I40E_QUEUE_NUM_PER_VM=8' config-test1 ninja -C config-test1 > > Regards, > Ma,lihong > > > -----Original Message----- > > From: dev On Behalf Of Bruce Richardson > > Sent: Tuesday, August 25, 2020 7:45 PM > > To: dev@dpdk.org > > Cc: bluca@debian.org; Richardson, Bruce > > Subject: [dpdk-dev] [PATCH 2/2] config: allow overriding some build > > defaults > > > > In case a developer uses CFLAGS to set different default values for > > the defines in the rte_config.h file, use #ifndef / #endif guards > > around the setting of those values. For those lines just "defining" a > > macro without assigning it a value to be used by code, drop the value > > argument (where > > possible) to make it clearer that that is what is happening, since > > those don't need the #ifdef guard. > > > > Signed-off-by: Bruce Richardson > > --- > > config/rte_config.h | 110 > > +++++++++++++++++++++++++++++++++++++++----- > > 1 file changed, 99 insertions(+), 11 deletions(-) > > > > diff --git a/config/rte_config.h b/config/rte_config.h index >