From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4097EA04BE; Wed, 2 Sep 2020 16:49:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A22B137D; Wed, 2 Sep 2020 16:49:22 +0200 (CEST) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id E5146E07 for ; Wed, 2 Sep 2020 16:49:20 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id m8so2972266pfh.3 for ; Wed, 02 Sep 2020 07:49:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7m1BQxWfheYkcdvFsbg3wvubBpLsumDCDdK9XnL8+Z8=; b=RVdWGiRyxwWbfZFhhjRCEokgZfhpr2UoWnsgIHGceG4CCgpoY/2iGrxsg/fvrglMf4 2PDOqlvWfM4q0LE4f4rng17/c0iCrbayyod6SZI3B5J/NjJsQ9u5dZjbf2QO2dl2P6hW XeTRnuPvsCh7xr/BvG1MMvqhInkRjHxkAkjkFLRXw7er1BBWcQe9Tn0aslg4bq/Oj/RW /18H5bT9nZmmSOiGebh8h2FJYB0d+cRndKsmdZNMNNps3iHYlG/+Ri100nU9p/s6uelx xoJbHp8cRYfoE5sX42gttuJC9HiiMXW8y9HqOHrlLg7G0TH5u8APBsPseihO4pJHaM95 Lywg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7m1BQxWfheYkcdvFsbg3wvubBpLsumDCDdK9XnL8+Z8=; b=tWDr+jdF2IpgbHRaT1aBw6GXn19eTlNjh9W1assmP74aG7CrZCU1OXg75qbvhylvPr YidhVwRq7QYp2WQ2nNUZvSOu1qSRMWaBb4TLCWQnVtONO7fs8ul7b1DF8gDSdHEaHu2D VIa+HLYTokZCKU2gOSXhf6rnOa8TIThfEKkaXWrRXVvgByJxpL1zg1TL/Zzwli0sDtXs 59/uRel679eKWMSHBZj0YbVJLfk4WyhCuwnu2ZdH4MTb5lz4lDBH8FZENQpuOWcMsLS5 NXPqD5ui5+idW08bh90T4H/dfHGnNFXb794Z1sRPuV3FUHnRSvrRGGci1YPuZ+CoJer0 G+jQ== X-Gm-Message-State: AOAM533fExfTl9GwVdG4U2zjOAeHjhSU6XPD1jD04YtlUCFtZO0dvLba zilUGeF7CgOXifL2eX5AiY9Plg== X-Google-Smtp-Source: ABdhPJz0Zvg5h8omPUCgYJRuWxyl+R2QGlsxl2F9fthMGF6idkGIj62RMogCRIWH6u5x0ucKf3XX/w== X-Received: by 2002:aa7:91ce:: with SMTP id z14mr3355517pfa.241.1599058159956; Wed, 02 Sep 2020 07:49:19 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id e3sm5698192pgu.40.2020.09.02.07.49.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2020 07:49:19 -0700 (PDT) Date: Wed, 2 Sep 2020 07:49:10 -0700 From: Stephen Hemminger To: David Marchand Cc: Ray Kinsella , Neil Horman , John McNamara , Marko Kovacevic , dev Message-ID: <20200902074910.04c68631@hermes.lan> In-Reply-To: References: <20200827225414.6623-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] rte_log: make rte_logs private X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 2 Sep 2020 10:40:19 +0200 David Marchand wrote: > On Fri, Aug 28, 2020 at 12:54 AM Stephen Hemminger > wrote: > > > > As announced in earlier releases, rte_logs can now be made > > internal to eal_common_log. > > I had prepared this cleanup before my PTO and was about to send it. > Just to avoid duplicate work, do you intend to work on other cleanups ? > > > Hiding this symbol is fine, but we must remove the experimental tag on > rte_log_get_stream since it becomes the only way to access the log > stream. > > More comments below. > Thanks. No intention on doing other cleanups, just saw this while implementing a log stream provider. Agree, the rte_log_get_stream() can be permanent API now.