From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40760A04BB; Wed, 2 Sep 2020 13:21:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2035FE07; Wed, 2 Sep 2020 13:21:53 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 50AC7255 for ; Wed, 2 Sep 2020 13:21:51 +0200 (CEST) IronPort-SDR: KlSTjC7Zf7sYWDko8uoUX1PwyAiKO+zyVb3rTXcf7pgdd13S8sSkSzNjBhWHoWwDGlR3lT9Tju H3p8lCTWWHhw== X-IronPort-AV: E=McAfee;i="6000,8403,9731"; a="242188749" X-IronPort-AV: E=Sophos;i="5.76,381,1592895600"; d="scan'208";a="242188749" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2020 04:21:50 -0700 IronPort-SDR: QL+q5DhSHEVT4BQXf5bBnFiFC340oGfzKny08mAdv2lHuGdcLkkrWSamVEaA7XKNM/rBmBQvZg elPdEwD6yStQ== X-IronPort-AV: E=Sophos;i="5.76,381,1592895600"; d="scan'208";a="477601260" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.3.68]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 02 Sep 2020 04:21:47 -0700 Date: Wed, 2 Sep 2020 12:21:44 +0100 From: Bruce Richardson To: Radu Nicolau Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com, viktorin@rehivetech.com, ruifeng.wang@arm.com, jerinj@marvell.com, drc@linux.vnet.ibm.com, konstantin.ananyev@intel.com, Sean Morrissey Message-ID: <20200902112144.GC1064@bricha3-MOBL.ger.corp.intel.com> References: <20200902104343.31774-1-radu.nicolau@intel.com> <20200902104343.31774-5-radu.nicolau@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200902104343.31774-5-radu.nicolau@intel.com> Subject: Re: [dpdk-dev] [PATCH v1 4/4] doc: remove reference to RTE_MACHINE_CPUFLAG X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 02, 2020 at 10:43:43AM +0000, Radu Nicolau wrote: > RTE_MACHINE_CPUFLAG macros are replaced with predefined > compiler defines. > > Signed-off-by: Sean Morrissey > Signed-off-by: Radu Nicolau > --- > doc/guides/prog_guide/writing_efficient_code.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/guides/prog_guide/writing_efficient_code.rst b/doc/guides/prog_guide/writing_efficient_code.rst > index 2639ef7bf..c1f2d627a 100644 > --- a/doc/guides/prog_guide/writing_efficient_code.rst > +++ b/doc/guides/prog_guide/writing_efficient_code.rst > @@ -273,5 +273,5 @@ main() function and checks if the current machine is suitable for running the bi > Along with compiler optimizations, > a set of preprocessor defines are automatically added to the build process (regardless of the compiler version). > These defines correspond to the instruction sets that the target CPU should be able to support. > -For example, a binary compiled for any SSE4.2-capable processor will have RTE_MACHINE_CPUFLAG_SSE4_2 defined, > +For example, a binary compiled for any SSE4.2-capable processor will have a pre-defined compiler macro, > thus enabling compile-time code path selection for different platforms. > -- Personally, I'd suggest just removing the whole section rather than part of a single line.