From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Ma Lihong <lihongx.ma@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH v2 1/3] config: remove explicit undefinition of unset values
Date: Thu, 3 Sep 2020 15:49:40 +0100 [thread overview]
Message-ID: <20200903144942.671870-2-bruce.richardson@intel.com> (raw)
In-Reply-To: <20200903144942.671870-1-bruce.richardson@intel.com>
Rather than explicitly clearing any setting of undefined values in our
rte_config.h file, it's better to instead just add a comment that the value
is not set. Using a comment allows the user to set the value using CFLAGS
or similar mechanism without the config file clearing the value again.
The text used "<VALUE> is not set" is modelled after the kernel approach of
doing the same thing.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
Although DPDK coding convention forbids use of "//" for comments, using
regular C comment style makes the config settings less clear, as they can
be confused with regular comments in the file. Using "//" makes them stand
out better, so I prefer it. However, if others feel strongly, they can be
changed to standard.
---
config/rte_config.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/config/rte_config.h b/config/rte_config.h
index 9bb915347..1c5a86d6a 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -85,17 +85,17 @@
/* ip_fragmentation defines */
#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 4
-#undef RTE_LIBRTE_IP_FRAG_TBL_STAT
+// RTE_LIBRTE_IP_FRAG_TBL_STAT is not set
/* rte_power defines */
#define RTE_MAX_LCORE_FREQS 64
/* rte_sched defines */
-#undef RTE_SCHED_RED
-#undef RTE_SCHED_COLLECT_STATS
-#undef RTE_SCHED_SUBPORT_TC_OV
+// RTE_SCHED_RED is not set
+// RTE_SCHED_COLLECT_STATS is not set
+// RTE_SCHED_SUBPORT_TC_OV is not set
#define RTE_SCHED_PORT_N_GRINDERS 8
-#undef RTE_SCHED_VECTOR
+// RTE_SCHED_VECTOR is not set
/* KNI defines */
#define RTE_KNI_PREEMPT_DEFAULT 1
@@ -123,7 +123,7 @@
/* i40e defines */
#define RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC 1
-#undef RTE_LIBRTE_I40E_16BYTE_RX_DESC
+// RTE_LIBRTE_I40E_16BYTE_RX_DESC is not set
#define RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF 64
#define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF 4
#define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM 4
--
2.25.1
next prev parent reply other threads:[~2020-09-03 14:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 11:44 [dpdk-dev] [PATCH 1/2] " Bruce Richardson
2020-08-25 11:44 ` [dpdk-dev] [PATCH 2/2] config: allow overriding some build defaults Bruce Richardson
2020-09-01 5:17 ` Ma, LihongX
2020-09-01 6:07 ` Hemant Agrawal
2020-09-01 9:02 ` Bruce Richardson
2020-09-03 14:50 ` Bruce Richardson
2020-09-03 14:49 ` [dpdk-dev] [PATCH v2 0/3] Allow overriding of build-time constants Bruce Richardson
2020-09-03 14:49 ` Bruce Richardson [this message]
2020-09-03 14:49 ` [dpdk-dev] [PATCH v2 2/3] config: allow overriding some build defaults Bruce Richardson
2020-09-03 14:49 ` [dpdk-dev] [PATCH v2 3/3] doc: add notes on overriding extra config values Bruce Richardson
2020-09-03 15:43 ` Hemant Agrawal
2020-10-14 14:20 ` [dpdk-dev] [PATCH v2 0/3] Allow overriding of build-time constants Bruce Richardson
2020-10-15 8:55 ` Chen, BoX C
2020-10-15 9:20 ` Bruce Richardson
2020-10-16 15:47 ` David Marchand
2020-10-16 15:55 ` Bruce Richardson
2020-10-16 16:46 ` David Marchand
2020-10-19 10:21 ` Bruce Richardson
2020-10-19 21:04 ` Thomas Monjalon
2020-10-20 8:34 ` Bruce Richardson
2020-10-20 10:04 ` Thomas Monjalon
2020-10-20 10:15 ` Bruce Richardson
2020-10-28 16:32 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903144942.671870-2-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=lihongx.ma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).