From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF0AAA04C5; Fri, 4 Sep 2020 11:31:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 30C711C0C6; Fri, 4 Sep 2020 11:31:30 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 13DA0DE0 for ; Fri, 4 Sep 2020 11:31:27 +0200 (CEST) IronPort-SDR: MMUIJTCR3kwBMfsz8nE8c7eU4MGM40fW0WBDc1Bset/e94AnF6/7Y9Wqm++BQngUAqYee4CmIO 6Wl0K9dRsrDw== X-IronPort-AV: E=McAfee;i="6000,8403,9733"; a="155114401" X-IronPort-AV: E=Sophos;i="5.76,389,1592895600"; d="scan'208";a="155114401" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2020 02:31:26 -0700 IronPort-SDR: GFMtEWzguHujHFmphA4eBkCG5NdAS835O7q9b2OUWVLjVDFlVCKoJ3isq57QeuRdKTnIZt7HUp vnAwa89WL4cA== X-IronPort-AV: E=Sophos;i="5.76,389,1592895600"; d="scan'208";a="478416743" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.81.45]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 04 Sep 2020 02:31:25 -0700 Date: Fri, 4 Sep 2020 10:31:21 +0100 From: Bruce Richardson To: Nicolas Chautru Cc: dev@dpdk.org, akhil.goyal@nxp.com, ciara.power@intel.com Message-ID: <20200904093121.GC1627@bricha3-MOBL.ger.corp.intel.com> References: <1599181535-37826-1-git-send-email-nicolas.chautru@intel.com> <1599181535-37826-2-git-send-email-nicolas.chautru@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1599181535-37826-2-git-send-email-nicolas.chautru@intel.com> Subject: Re: [dpdk-dev] [PATCH v1] baseband/turbo_sw: update meson for more dynamic compilation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 03, 2020 at 06:05:35PM -0700, Nicolas Chautru wrote: > The meson for the turbo_sw PMD is updated to prevent the > requirement for any device specific toplevel flags to be > passed down (unlike what used to be the case with make). > The linking to the optional libraries is purely auto > detected at build time and flags are then set appropriately. > > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/turbo_sw/meson.build | 43 ++++++++++++++++++----------------- > 1 file changed, 22 insertions(+), 21 deletions(-) > >From a meson viewpoint this all looks good, and glad to see the driver taking advantage of the dynamic probing. Acked-by: Bruce Richardson