From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E367A04C5; Fri, 4 Sep 2020 18:38:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 284FD1C0CD; Fri, 4 Sep 2020 18:38:01 +0200 (CEST) Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by dpdk.org (Postfix) with ESMTP id 775F71C0C6 for ; Fri, 4 Sep 2020 18:38:00 +0200 (CEST) Received: by mail-pj1-f66.google.com with SMTP id a9so257200pjg.1 for ; Fri, 04 Sep 2020 09:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZmBywFb81+ZX/DaWm80uUNgktgfT/aJZLOWhBlfRZHU=; b=Qytha9FtYxHLo6+kp8eU2GrVFbdicPYOajMKtVQCxwWFK+Hs75YvPzJ4Dpegt3EH4I a6v+xTWv0Tq0uZgC25N8GZcnRzV+GZnOk7GcB+JutF0EvfOWc9BQTRbE17sC6prMzPrT HdDFH4Q+PCMajdkXdoV6ORmVwUnuR5cEH+JD9ysG3ZjBN+B3V7c2E6TbjXFH1Im09eUm a81uiGjthJcsBELn/pfflApy2aSSbNZQNHNkiDt0UoGiQ2Y5t0LpYCsx37dPu9PugDV8 FMSibFFgsVX9bjI2Qvv1WeUlwrB8DTvApat4d16MQv4j6ZbBK4PkzG3PR4vqPD6xnK9C +2wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZmBywFb81+ZX/DaWm80uUNgktgfT/aJZLOWhBlfRZHU=; b=ZWUBLihXfw7iwvl/IhNUEwrUR0J0o2edwbb2MFGU4B60juWjHd1WtanJKhCW2PkC+L 9cqEGomiOvajAqJLiVdMifabMMCxTOo7Bu49u4JYdL/esg7/pFQ0Nn9QxCTsJqmHTzvf OQT/Jo3G0L/fXaYjHD/Z6UCsw9SPD8HE3zZbtYpcIIaPN6fifQF0yuVqwCqmX31Tn3Tg q7D2dwg6kRJMkDak+ryl/9IvreqM6BVcW6IaPMTLXDtlStd6TD86iAR4zh1p/jTtws4r YEJw6HkwVzBx5u2Q7MwEWn7h1M5C0NGLPuIDVpERyVrjzKqXhbEX921HPywWHHQonfdd 9tyA== X-Gm-Message-State: AOAM531n51ChCDtP7uas4KQXC6pTF3I75jI9HRb0g3C2+lyGSxJllGXb 49nZE0hjV4njqUVwNxIgXZ3mIw== X-Google-Smtp-Source: ABdhPJxCXSXDEXaybVQaGLA1eiVs57Z3+4/MEqsp8feRUzSpZB2JE85RSOYWKVrgWpy+XC73NZMxJQ== X-Received: by 2002:a17:90a:19dc:: with SMTP id 28mr8759043pjj.103.1599237479699; Fri, 04 Sep 2020 09:37:59 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id j193sm3652734pfd.89.2020.09.04.09.37.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2020 09:37:59 -0700 (PDT) Date: Fri, 4 Sep 2020 09:37:57 -0700 From: Stephen Hemminger To: Liang Ma Cc: dev@dpdk.org, david.hunt@intel.com, anatoly.burakov@intel.com Message-ID: <20200904093757.1d3e67f3@hermes.lan> In-Reply-To: <1599214740-3927-1-git-send-email-liang.j.ma@intel.com> References: <1597141666-20621-1-git-send-email-liang.j.ma@intel.com> <1599214740-3927-1-git-send-email-liang.j.ma@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 4 Sep 2020 11:18:55 +0100 Liang Ma wrote: > Add two new power management intrinsics, and provide an implementation > in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions > are implemented as raw byte opcodes because there is not yet widespread > compiler support for these instructions. > > The power management instructions provide an architecture-specific > function to either wait until a specified TSC timestamp is reached, or > optionally wait until either a TSC timestamp is reached or a memory > location is written to. The monitor function also provides an optional > comparison, to avoid sleeping when the expected write has already > happened, and no more writes are expected. > > Signed-off-by: Liang Ma > Signed-off-by: Anatoly Burakov This looks like a useful feature but needs more documentation and example. It would make sense to put an example in l3fwd-power.