From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 01BDAA04C5;
Sat, 5 Sep 2020 05:00:56 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 08A991C131;
Sat, 5 Sep 2020 04:59:58 +0200 (CEST)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
by dpdk.org (Postfix) with ESMTP id AC9561C116;
Sat, 5 Sep 2020 04:59:56 +0200 (CEST)
IronPort-SDR: OT+/Ih8PnDBT8IlaFL3K5aptUbzWa6zCuOv/KIF2FW2jRomtd0UxRaMiHrFoRCuNY6ke5l6TGt
kSQZARKmuXdQ==
X-IronPort-AV: E=McAfee;i="6000,8403,9734"; a="137886700"
X-IronPort-AV: E=Sophos;i="5.76,392,1592895600"; d="scan'208";a="137886700"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
04 Sep 2020 19:59:56 -0700
IronPort-SDR: oyvulo+kNmtXRxMaSB0uKbICfJGMCUCTeD3K0PLY8h/YdT9GNYHg1RbgrXSi1WgDyBceA3cc2E
Z+fyP+tyisAA==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.76,392,1592895600"; d="scan'208";a="406052747"
Received: from unknown (HELO localhost.localdomain) ([10.239.255.52])
by fmsmga001.fm.intel.com with ESMTP; 04 Sep 2020 19:59:54 -0700
From: Guinan Sun <guinanx.sun@intel.com>
To: dev@dpdk.org
Cc: Beilei Xing <beilei.xing@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
Qiming Yang <qiming.yang@intel.com>, Guinan Sun <guinanx.sun@intel.com>,
stable@dpdk.org, Galazka Krzysztof <krzysztof.galazka@intel.com>
Date: Sat, 5 Sep 2020 02:49:37 +0000
Message-Id: <20200905024938.14609-9-guinanx.sun@intel.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20200905024938.14609-1-guinanx.sun@intel.com>
References: <20200905024938.14609-1-guinanx.sun@intel.com>
Subject: [dpdk-dev] [PATCH 8/9] net/i40e/base: fix PHY config param when
enabling EEE
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
The i40e_enable_eee function did not copy phy_type_ext field
from current PHY configuration retrieved with Get PHY Abilities AQ.
It caused a misconfiguration of the PHY on devices supporting 2.5
and 5G speeds and prevented establishing link when only those
speeds were selected for advertisement.
Fixes: c61bcb0fe1b0 ("net/i40e/base: support Energy Efficient Ethernet")
Cc: stable@dpdk.org
Signed-off-by: Galazka Krzysztof <krzysztof.galazka@intel.com>
Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
---
drivers/net/i40e/base/i40e_common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c
index 073634278..e62d63c68 100644
--- a/drivers/net/i40e/base/i40e_common.c
+++ b/drivers/net/i40e/base/i40e_common.c
@@ -6449,6 +6449,7 @@ enum i40e_status_code i40e_enable_eee(struct i40e_hw *hw, bool enable)
/* Cache current configuration */
config.phy_type = abilities.phy_type;
+ config.phy_type_ext = abilities.phy_type_ext;
config.link_speed = abilities.link_speed;
config.abilities = abilities.abilities |
I40E_AQ_PHY_ENABLE_ATOMIC_LINK;
--
2.17.1