From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9784AA04C5; Sat, 5 Sep 2020 18:50:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ABBFE2BF1; Sat, 5 Sep 2020 18:50:52 +0200 (CEST) Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by dpdk.org (Postfix) with ESMTP id DC6B4255 for ; Sat, 5 Sep 2020 18:50:50 +0200 (CEST) Received: by mail-pj1-f67.google.com with SMTP id b17so2308175pji.1 for ; Sat, 05 Sep 2020 09:50:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=insy8tg5lsikKnmjGuoIatX3kuyWsB8CFvI72IX9pk4=; b=rEfgpkLgkufyptWtnv2iLrohyu3y7szmJrrCahuaJmI8OTkgrDiDCZt3JfmyaWgviZ 44AfzGLXZ5bpDNnqym8Ozjt/gil+DUAY70bzwdz46JXEBj2iQRjWb1LoAMuyqvbKR7AF bb+QAvS0URxSmM0wxNjAxx3ORUBqSdv0YjNT9MDfO1WTjtaH4gpHbLwDyIHtqeBb2ta5 9MVeYpE+2kOjdCgsnM6Om7LHVHOx+dVVuLQG18MLy4wdR8HR+XzjBfmZJZYLJGtMEvri 5mO7EfOkY126SkfeV1IOGGdQeHmTa3PM/9/pCfOeOp7Gixoh6GXN/rcUTRG13VlgsUwt tXOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=insy8tg5lsikKnmjGuoIatX3kuyWsB8CFvI72IX9pk4=; b=NUCAcvFR/jlnt9K/OAGb1CyvBd4pdfQkIpDUuEp7zMvb52CcQ9xEYWrHCC+gIleemg yNo1OlV7LGY3UB0IvduXxT0WroowXj6WD3pjS9gDjAecRTL+rICNjwFE1i21p0oMR0VW jJaQw94trKwcHiJk0o7Prc/43Nm/IF/7MzkQ0TbcF1V+kWieRe6bSDETo4qGg/+R1pu1 HBPPLhdBlYbbJS0emZTRRy2lpsmxZ/jCqGR8jDYtDBCjlRibo58exSeIzDCI0wYHOneu VsfQFlvPIPt99L3KE1CCxUvIK36bagjkjB+IqSqghU9LBP+0MDITubZDvtVgj9OQR04y kd/A== X-Gm-Message-State: AOAM533jBwdJwUxHGN/RORbYMqDuhmxRLpXHEJJeUobZAGqkD1efVHiw mIdzsOG5tSLIpQAo/6dC/MCF6Q== X-Google-Smtp-Source: ABdhPJyabq2xnCPjhQpgBjkp9VJQ2BYm4x3vW+F5uyqjpv35rsnoNFLq4fcn/euAvcRzu4J/Z6e/7w== X-Received: by 2002:a17:902:7404:: with SMTP id g4mr13741709pll.176.1599324649915; Sat, 05 Sep 2020 09:50:49 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 25sm2241691pfj.35.2020.09.05.09.50.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Sep 2020 09:50:49 -0700 (PDT) Date: Sat, 5 Sep 2020 09:50:41 -0700 From: Stephen Hemminger To: Chengchang Tang Cc: , , , , , , Message-ID: <20200905095041.3fb6ea5b@hermes.lan> In-Reply-To: <1599296854-56620-2-git-send-email-tangchengchang@huawei.com> References: <1592483709-7076-1-git-send-email-tangchengchang@huawei.com> <1599296854-56620-1-git-send-email-tangchengchang@huawei.com> <1599296854-56620-2-git-send-email-tangchengchang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 1/5] ethdev: add a field for rxq info structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, 5 Sep 2020 17:07:30 +0800 Chengchang Tang wrote: > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index 70295d7..859111a 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1420,6 +1420,8 @@ struct rte_eth_rxq_info { > struct rte_eth_rxconf conf; /**< queue config parameters. */ > uint8_t scattered_rx; /**< scattered packets RX supported. */ > uint16_t nb_desc; /**< configured number of RXDs. */ > + /**< Buffer size used for HW when receive packets. */ > + uint16_t rx_buf_size; Minor suggestion. If you shorten the comment (which is not that useful) and use the same case, then it will fit on the same line and look like the rest of the code. uint16_t rx_buf_size; /**< hardware receive buffer size */