From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3ABFAA04B9; Mon, 7 Sep 2020 10:58:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 86CA11BE85; Mon, 7 Sep 2020 10:58:34 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 201931BE0C for ; Mon, 7 Sep 2020 10:58:32 +0200 (CEST) IronPort-SDR: /Mr7YgV6QrMT5D4pETrcKJSRQs81VBa8LRDG0qQSxryD+iU3jVTW6Dn1uJkSuQHO5pQjBWhUBp v1kgr1M4BuGg== X-IronPort-AV: E=McAfee;i="6000,8403,9736"; a="157990421" X-IronPort-AV: E=Sophos;i="5.76,401,1592895600"; d="scan'208";a="157990421" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2020 01:58:32 -0700 IronPort-SDR: UU+KJCU4J2u0jrKMrvQaShxZNWLNsQx3zwdKTnTniyIkUpnXWXRu5fzsMHFe7nx3SgKfTrrRez NXmImaSaQAgg== X-IronPort-AV: E=Sophos;i="5.76,401,1592895600"; d="scan'208";a="479573803" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.80.24]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 07 Sep 2020 01:58:30 -0700 Date: Mon, 7 Sep 2020 09:58:27 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: Stephen Hemminger , dev@dpdk.org Message-ID: <20200907085827.GC312@bricha3-MOBL.ger.corp.intel.com> References: <20200901165643.15668-1-stephen@networkplumber.org> <20200906034247.25111-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v5] usertools: add huge page setup script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 07, 2020 at 09:54:29AM +0100, Ferruh Yigit wrote: > On 9/6/2020 4:42 AM, Stephen Hemminger wrote: > > This is an improved version of the setup of huge pages > > bases on earlier DPDK setup. Differences are: > > * it autodetects NUMA vs non NUMA > > * it allows setting different page sizes > > recent kernels support multiple sizes. > > * it accepts a parameter in bytes (not pages). > > > > If necessary the steps of clearing old settings and mounting/umounting > > can be done individually. > > > > Signed-off-by: Stephen Hemminger > > <...> > > > @@ -1,4 +1,9 @@ > > # SPDX-License-Identifier: BSD-3-Clause > > # Copyright(c) 2017 Intel Corporation > > > > -install_data(['dpdk-devbind.py', 'dpdk-pmdinfo.py', 'dpdk-telemetry.py'], install_dir: 'bin') > > +install_data([ > > + 'dpdk-devbind.py', > > + 'dpdk-pmdinfo.py', > > + 'dpdk-telemetry.py', > > + 'hugepage_setup.py' > > +],install_dir: 'bin') > > > > Should script name has 'dpdk-' prefix as others do? +1 to that.